Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/kern Remove, in do_sys_renameat(), wrong KASSERTs that c...



details:   https://anonhg.NetBSD.org/src/rev/8700468a8dd5
branches:  trunk
changeset: 788802:8700468a8dd5
user:      njoly <njoly%NetBSD.org@localhost>
date:      Sat Jul 20 15:55:57 2013 +0000

description:
Remove, in do_sys_renameat(), wrong KASSERTs that check for non NULL
from/to arguments. Such values are correctly handled by later
pathbuf_maybe_copyin() calls, that will fail with EFAULT.

ok from dholland@.

diffstat:

 sys/kern/vfs_syscalls.c |  6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diffs (27 lines):

diff -r ca0d1ca349d0 -r 8700468a8dd5 sys/kern/vfs_syscalls.c
--- a/sys/kern/vfs_syscalls.c   Sat Jul 20 14:15:20 2013 +0000
+++ b/sys/kern/vfs_syscalls.c   Sat Jul 20 15:55:57 2013 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: vfs_syscalls.c,v 1.466 2013/07/18 14:06:27 matt Exp $  */
+/*     $NetBSD: vfs_syscalls.c,v 1.467 2013/07/20 15:55:57 njoly Exp $ */
 
 /*-
  * Copyright (c) 2008, 2009 The NetBSD Foundation, Inc.
@@ -70,7 +70,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: vfs_syscalls.c,v 1.466 2013/07/18 14:06:27 matt Exp $");
+__KERNEL_RCSID(0, "$NetBSD: vfs_syscalls.c,v 1.467 2013/07/20 15:55:57 njoly Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_fileassoc.h"
@@ -4169,8 +4169,6 @@
        int error;
 
        KASSERT(l != NULL || (fromfd == AT_FDCWD && tofd == AT_FDCWD));
-       KASSERT(from != NULL);
-       KASSERT(to != NULL);
 
        error = pathbuf_maybe_copyin(from, seg, &fpb);
        if (error)



Home | Main Index | Thread Index | Old Index