Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/rump/dev/lib/libopencrypto reduce rump waring message. p...



details:   https://anonhg.NetBSD.org/src/rev/75968ceb50fc
branches:  trunk
changeset: 825072:75968ceb50fc
user:      knakahara <knakahara%NetBSD.org@localhost>
date:      Thu Jun 29 08:51:27 2017 +0000

description:
reduce rump waring message. pointed out by ozaki-r@n.o, thanks.

diffstat:

 sys/rump/dev/lib/libopencrypto/opencrypto_component.c |  19 +++++++++++++++++--
 1 files changed, 17 insertions(+), 2 deletions(-)

diffs (39 lines):

diff -r 75c2896ea11d -r 75968ceb50fc sys/rump/dev/lib/libopencrypto/opencrypto_component.c
--- a/sys/rump/dev/lib/libopencrypto/opencrypto_component.c     Thu Jun 29 07:15:27 2017 +0000
+++ b/sys/rump/dev/lib/libopencrypto/opencrypto_component.c     Thu Jun 29 08:51:27 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: opencrypto_component.c,v 1.4 2016/01/26 23:12:15 pooka Exp $ */
+/*     $NetBSD: opencrypto_component.c,v 1.5 2017/06/29 08:51:27 knakahara Exp $ */
 
 /*
  * Copyright (c) 2009 Antti Kantee.  All Rights Reserved.
@@ -26,7 +26,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: opencrypto_component.c,v 1.4 2016/01/26 23:12:15 pooka Exp $");
+__KERNEL_RCSID(0, "$NetBSD: opencrypto_component.c,v 1.5 2017/06/29 08:51:27 knakahara Exp $");
 
 #include <sys/param.h>
 #include <sys/conf.h>
@@ -64,5 +64,20 @@
         */
        crypto_init();
        rump_pdev_add(cryptoattach, 1);
+#if 0
+       /*
+        * rump defines "_MODULE" in spite of using built-in module
+        * initialization(module_init_class()). So, swcryptoattach_internal()
+        * is called by two functions, one is swcryptoattach() and the other is
+        * swcrypto_modcmd().
+        * That causes "builtin module `swcrypto' failed to init" WARNING message.
+        * To suppress this warning, we let rump use swcrypto_modcmd() call-path
+        * only.
+        *
+        * TODO:
+        * There is still "crypto: unable to register devsw" message. it should
+        * be suppressed.
+        */
        rump_pdev_add(swcryptoattach, 0);
+#endif
 }



Home | Main Index | Thread Index | Old Index