[src/trunk]: src/lib/libc/net PR/50367: Stefan Schaeckeler: Apply fix to obey...

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/b9c53e6e0bf9
branches:  trunk
changeset: 811361:b9c53e6e0bf9
user:      christos <christos%NetBSD.org@localhost>
date:      Mon Oct 26 19:28:53 2015 +0000

description:
PR/50367: Stefan Schaeckeler: Apply fix to obey RES_CHECKNAME to getnetbyaddr
and getnetbyname.

diffstat:

 lib/libc/net/getnetnamadr.c |  23 +++++++++++++++--------
 1 files changed, 15 insertions(+), 8 deletions(-)

diffs (93 lines):

diff -r c394b3f403f7 -r b9c53e6e0bf9 lib/libc/net/getnetnamadr.c
--- a/lib/libc/net/getnetnamadr.c       Mon Oct 26 17:23:00 2015 +0000
+++ b/lib/libc/net/getnetnamadr.c       Mon Oct 26 19:28:53 2015 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: getnetnamadr.c,v 1.42 2012/03/13 21:13:41 christos Exp $       */
+/*     $NetBSD: getnetnamadr.c,v 1.43 2015/10/26 19:28:53 christos Exp $       */
 
 /* Copyright (c) 1993 Carlos Leandro and Rui Salgueiro
  *     Dep. Matematica Universidade de Coimbra, Portugal, Europe
@@ -43,7 +43,7 @@
 static char sccsid_[] = "from getnetnamadr.c   1.4 (Coimbra) 93/06/03";
 static char rcsid[] = "Id: getnetnamadr.c,v 8.8 1997/06/01 20:34:37 vixie Exp ";
 #else
-__RCSID("$NetBSD: getnetnamadr.c,v 1.42 2012/03/13 21:13:41 christos Exp $");
+__RCSID("$NetBSD: getnetnamadr.c,v 1.43 2015/10/26 19:28:53 christos Exp $");
 #endif
 #endif /* LIBC_SCCS and not lint */
 
@@ -77,6 +77,12 @@
 __weak_alias(getnetbyname,_getnetbyname)
 #endif
 
+#define maybe_ok(res, nm, ok) (((res)->options & RES_NOCHECKNAME) != 0U || \
+                               (ok)(nm) != 0)
+#define maybe_hnok(res, hn) maybe_ok((res), (hn), res_hnok)
+#define maybe_dnok(res, dn) maybe_ok((res), (dn), res_dnok)
+
+
 extern int _net_stayopen;
 
 #define BYADDR 0
@@ -105,7 +111,7 @@
 static char *net_aliases[MAXALIASES];
 
 static int             parse_reversed_addr(const char *, in_addr_t *);
-static struct netent   *getnetanswer(querybuf *, int, int);
+static struct netent   *getnetanswer(res_state, querybuf *, int, int);
 static int             _files_getnetbyaddr(void *, void *, va_list);
 static int             _files_getnetbyname(void *, void *, va_list);
 static int             _dns_getnetbyaddr(void *, void *, va_list);
@@ -159,7 +165,7 @@
 }
 
 static struct netent *
-getnetanswer(querybuf *answer, int anslen, int net_i)
+getnetanswer(res_state res, querybuf *answer, int anslen, int net_i)
 {
        static char     n_name[MAXDNAME];
        static char     netbuf[PACKETSZ];
@@ -172,6 +178,7 @@
        char            *in, *bp, **ap, *ep;
 
        _DIAGASSERT(answer != NULL);
+       _DIAGASSERT(res != NULL);
 
        /*
         * find first satisfactory answer
@@ -216,7 +223,7 @@
        n_name[0] = '\0';
        while (--ancount >= 0 && cp < eom) {
                n = dn_expand(answer->buf, eom, cp, bp, (int)(ep - bp));
-               if ((n < 0) || !res_dnok(bp))
+               if ((n < 0) || !maybe_dnok(res, bp))
                        break;
                cp += n;
                (void)strlcpy(n_name, bp, sizeof(n_name));
@@ -226,7 +233,7 @@
                GETSHORT(n, cp);
                if (class == C_IN && type == T_PTR) {
                        n = dn_expand(answer->buf, eom, cp, bp, (int)(ep - bp));
-                       if ((n < 0) || !res_hnok(bp)) {
+                       if ((n < 0) || !maybe_hnok(res, bp)) {
                                cp += n;
                                return NULL;
                        }
@@ -359,7 +366,7 @@
                return NS_NOTFOUND;
        }
        __res_put_state(res);
-       np = getnetanswer(buf, anslen, BYADDR);
+       np = getnetanswer(res, buf, anslen, BYADDR);
        free(buf);
        if (np) {
                /* maybe net should be unsigned? */
@@ -471,7 +478,7 @@
                return NS_NOTFOUND;
        }
        __res_put_state(res);
-       np = getnetanswer(buf, anslen, BYNAME);
+       np = getnetanswer(res, buf, anslen, BYNAME);
        free(buf);
 
        if (np != NULL) {