Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[src/trunk]: src/sys/fs/nilfs Revert previous, it was a false positive.
details: https://anonhg.NetBSD.org/src/rev/60e15c7774a7
branches: trunk
changeset: 806168:60e15c7774a7
user: maxv <maxv%NetBSD.org@localhost>
date: Sat Feb 07 10:40:57 2015 +0000
description:
Revert previous, it was a false positive.
In nilfs_mount_device() there's one branch where the node is not released:
when the device is already mounted. Not releasing it was thus intentional,
but this is something code scanners can't understand.
diffstat:
sys/fs/nilfs/nilfs_vfsops.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diffs (30 lines):
diff -r 0b6e8367d0a2 -r 60e15c7774a7 sys/fs/nilfs/nilfs_vfsops.c
--- a/sys/fs/nilfs/nilfs_vfsops.c Sat Feb 07 09:59:47 2015 +0000
+++ b/sys/fs/nilfs/nilfs_vfsops.c Sat Feb 07 10:40:57 2015 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: nilfs_vfsops.c,v 1.19 2015/02/07 04:25:16 christos Exp $ */
+/* $NetBSD: nilfs_vfsops.c,v 1.20 2015/02/07 10:40:57 maxv Exp $ */
/*
* Copyright (c) 2008, 2009 Reinoud Zandijk
@@ -28,7 +28,7 @@
#include <sys/cdefs.h>
#ifndef lint
-__KERNEL_RCSID(0, "$NetBSD: nilfs_vfsops.c,v 1.19 2015/02/07 04:25:16 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nilfs_vfsops.c,v 1.20 2015/02/07 10:40:57 maxv Exp $");
#endif /* not lint */
@@ -879,10 +879,8 @@
#endif
error = nilfs_mount_device(devvp, mp, args, &nilfsdev);
- if (error) {
- vrele(devvp);
+ if (error)
return error;
- }
/*
* Create a nilfs_mount on the specified checkpoint. Note that only
Home |
Main Index |
Thread Index |
Old Index