[src/jdolecek-ncq]: src/sys/dev/ata some notes around c_start/atastart()

[jdolecek <jdolecek%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/b1a2aeffad49
branches:  jdolecek-ncq
changeset: 823009:b1a2aeffad49
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Tue Aug 29 13:38:38 2017 +0000

description:
some notes around c_start/atastart()

diffstat:

 sys/dev/ata/TODO.ncq |  5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diffs (15 lines):

diff -r 916bb603d9f6 -r b1a2aeffad49 sys/dev/ata/TODO.ncq
--- a/sys/dev/ata/TODO.ncq      Tue Aug 15 20:12:28 2017 +0000
+++ b/sys/dev/ata/TODO.ncq      Tue Aug 29 13:38:38 2017 +0000
@@ -2,6 +2,11 @@
 ----
 test wd* at umass?, confirm the ata_channel kludge works
 
+c_start() needs to be called on splbio to avoid spurious irq during reset,
+is not e.g. in ata thread and may not in atastart() neither
+- wdc.c never calls atastart() (start always false)
+- ata_wdc.c calls atastart() regardless if error
+
 Other random notes (do outside the NCQ branch):
 -----------------------------------------------------
 do biodone() in wddone() starting the dump to not leak bufs when dumping from