[src/trunk]: src/sys/arch/arm/omap Always perform code previously code under ...

[skrll <skrll%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/cb83080dcccb
branches:  trunk
changeset: 826247:cb83080dcccb
user:      skrll <skrll%NetBSD.org@localhost>
date:      Wed Aug 23 14:14:59 2017 +0000

description:
Always perform code previously code under #ifdef DIAGNOSTIC - it appears
that the read is needed to help make the chip work.  Someone with time and
a datasheet can hopefully work out why.

Fixes John D. Baker's boot problem reported on port-arm here:

        http://mail-index.netbsd.org/port-arm/2017/07/27/msg004323.html

diffstat:

 sys/arch/arm/omap/am335x_prcm.c |  10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diffs (37 lines):

diff -r 9f01a6996480 -r cb83080dcccb sys/arch/arm/omap/am335x_prcm.c
--- a/sys/arch/arm/omap/am335x_prcm.c   Wed Aug 23 13:04:17 2017 +0000
+++ b/sys/arch/arm/omap/am335x_prcm.c   Wed Aug 23 14:14:59 2017 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: am335x_prcm.c,v 1.9 2016/10/18 15:10:35 kiyohara Exp $ */
+/*     $NetBSD: am335x_prcm.c,v 1.10 2017/08/23 14:14:59 skrll Exp $   */
 
 /*
  * TI OMAP Power, Reset, and Clock Management on the AM335x
@@ -34,7 +34,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: am335x_prcm.c,v 1.9 2016/10/18 15:10:35 kiyohara Exp $");
+__KERNEL_RCSID(0, "$NetBSD: am335x_prcm.c,v 1.10 2017/08/23 14:14:59 skrll Exp $");
 
 #include "tps65217pmic.h"
 
@@ -61,18 +61,12 @@
 am335x_prcm_check_clkctrl(bus_size_t cm_module,
     bus_size_t clkctrl_reg, uint32_t v)
 {
-#ifdef DIAGNOSTIC
        uint32_t u = prcm_read_4(cm_module, clkctrl_reg);
 
        if (__SHIFTOUT(u, AM335X_CLKCTRL_MODULEMODE_MASK) !=
            __SHIFTOUT(v, AM335X_CLKCTRL_MODULEMODE_MASK))
                aprint_error("clkctrl didn't take: %"PRIx32" -/-> %"PRIx32"\n",
                    u, v);
-#else
-       (void)cm_module;
-       (void)clkctrl_reg;
-       (void)v;
-#endif
 }
 
 void