Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/netinet Remove unnecessary LLE_REMREF



details:   https://anonhg.NetBSD.org/src/rev/80ff40a98e78
branches:  trunk
changeset: 813356:80ff40a98e78
user:      ozaki-r <ozaki-r%NetBSD.org@localhost>
date:      Mon Jan 25 10:15:38 2016 +0000

description:
Remove unnecessary LLE_REMREF

The code around it was copied from arptimer, but LLE_REMREF
is unnecessary because it is needed only for arptimer that
is called after LLE_ADDREF.

This is a possible fix for PR#50548, PR#50702 and PR#50704.

diffstat:

 sys/netinet/if_arp.c |  5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diffs (26 lines):

diff -r 4cd93c91502d -r 80ff40a98e78 sys/netinet/if_arp.c
--- a/sys/netinet/if_arp.c      Mon Jan 25 09:24:29 2016 +0000
+++ b/sys/netinet/if_arp.c      Mon Jan 25 10:15:38 2016 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_arp.c,v 1.202 2016/01/21 15:41:30 riastradh Exp $   */
+/*     $NetBSD: if_arp.c,v 1.203 2016/01/25 10:15:38 ozaki-r Exp $     */
 
 /*-
  * Copyright (c) 1998, 2000, 2008 The NetBSD Foundation, Inc.
@@ -68,7 +68,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_arp.c,v 1.202 2016/01/21 15:41:30 riastradh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_arp.c,v 1.203 2016/01/25 10:15:38 ozaki-r Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_ddb.h"
@@ -714,7 +714,6 @@
                if (la->la_flags & LLE_LINKED) {
                        size_t pkts_dropped;
 
-                       LLE_REMREF(la);
                        pkts_dropped = llentry_free(la);
                        ARP_STATADD(ARP_STAT_DFRDROPPED, pkts_dropped);
                } else {



Home | Main Index | Thread Index | Old Index