[pkgsrc/trunk]: pkgsrc/misc/superkaramba Order of pointers and 0 is undefined.

[joerg <joerg%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/d6271d090500
branches:  trunk
changeset: 431584:d6271d090500
user:      joerg <joerg%pkgsrc.org@localhost>
date:      Thu May 14 19:20:17 2020 +0000

description:
Order of pointers and 0 is undefined.

diffstat:

 misc/superkaramba/distinfo                          |   4 +++-
 misc/superkaramba/patches/patch-src_sensors_rss.cpp |  13 +++++++++++++
 misc/superkaramba/patches/patch-src_taskmanager.cpp |  17 +++++++++++++++++
 3 files changed, 33 insertions(+), 1 deletions(-)

diffs (52 lines):

diff -r ddeaf024c8eb -r d6271d090500 misc/superkaramba/distinfo
--- a/misc/superkaramba/distinfo        Thu May 14 19:19:56 2020 +0000
+++ b/misc/superkaramba/distinfo        Thu May 14 19:20:17 2020 +0000
@@ -1,7 +1,9 @@
-$NetBSD: distinfo,v 1.11 2016/01/10 19:27:41 markd Exp $
+$NetBSD: distinfo,v 1.12 2020/05/14 19:20:17 joerg Exp $
 
 SHA1 (superkaramba-15.08.3.tar.xz) = 930ee6e49c75723b9b22359f35911aefdb382183
 RMD160 (superkaramba-15.08.3.tar.xz) = c103f83df8e8e4b320c8fbee0711995aa8c3fc27
 SHA512 (superkaramba-15.08.3.tar.xz) = 4e00d1a783330eea15f32394c26a64e66ddabd63d84cdc61ec6df1c14311e93ab3b40439ce63d38234330f6ffda5ab447d4c6da119c1bf68146caaa6be02025b
 Size (superkaramba-15.08.3.tar.xz) = 381808 bytes
 SHA1 (patch-src_sensors_mem.cpp) = b95cf1c87821e0f01828646d4a23d46fa0368a02
+SHA1 (patch-src_sensors_rss.cpp) = 6775acda306fde5787b876e95efc2a700e71eb18
+SHA1 (patch-src_taskmanager.cpp) = 05245219553fba5e60ed45359fc80023eb6593d7
diff -r ddeaf024c8eb -r d6271d090500 misc/superkaramba/patches/patch-src_sensors_rss.cpp
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/misc/superkaramba/patches/patch-src_sensors_rss.cpp       Thu May 14 19:20:17 2020 +0000
@@ -0,0 +1,13 @@
+$NetBSD: patch-src_sensors_rss.cpp,v 1.1 2020/05/14 19:20:17 joerg Exp $
+
+--- src/sensors/rss.cpp.orig   2020-05-13 22:19:59.121304123 +0000
++++ src/sensors/rss.cpp
+@@ -79,7 +79,7 @@ void RssSensor::update()
+             if (!n.isNull()) {
+                 QDomNodeList links = docElem.elementsByTagName("link");
+                 QDomNodeList displays;
+-                if (format.contains("%d", Qt::CaseInsensitive) > 0) {
++                if (format.contains("%d", Qt::CaseInsensitive)) {
+                     displays = docElem.elementsByTagName("description");
+                 } else {
+                     displays = docElem.elementsByTagName("title");
diff -r ddeaf024c8eb -r d6271d090500 misc/superkaramba/patches/patch-src_taskmanager.cpp
--- /dev/null   Thu Jan 01 00:00:00 1970 +0000
+++ b/misc/superkaramba/patches/patch-src_taskmanager.cpp       Thu May 14 19:20:17 2020 +0000
@@ -0,0 +1,17 @@
+$NetBSD: patch-src_taskmanager.cpp,v 1.1 2020/05/14 19:20:17 joerg Exp $
+
+--- src/taskmanager.cpp.orig   2020-05-13 22:17:09.187513832 +0000
++++ src/taskmanager.cpp
+@@ -908,10 +908,10 @@ bool Task::idMatch(const QString& id1, c
+     if (id1.isEmpty() || id2.isEmpty())
+         return false;
+ 
+-    if (id1.contains(id2) > 0)
++    if (id1.contains(id2))
+         return true;
+ 
+-    if (id2.contains(id1) > 0)
++    if (id2.contains(id1))
+         return true;
+ 
+     return false;