Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[pkgsrc/trunk]: pkgsrc mark packages that fail with -Werror=char-subscripts
details: https://anonhg.NetBSD.org/pkgsrc/rev/39fb6f0f5d67
branches: trunk
changeset: 432254:39fb6f0f5d67
user: rillig <rillig%pkgsrc.org@localhost>
date: Wed May 20 06:09:03 2020 +0000
description:
mark packages that fail with -Werror=char-subscripts
These packages are susceptible to bugs when confronted with non-ASCII
characters.
See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94182.
It takes some time to analyze and fix these individually, therefore they
are only marked as "needs work".
diffstat:
audio/goom/Makefile | 9 ++++++++-
audio/mpegaudio/Makefile | 12 +++++++++++-
biology/lucy/Makefile | 9 ++++++++-
cad/fasthenry/Makefile | 9 ++++++++-
cad/magic/Makefile | 8 +++++++-
cad/spice/Makefile | 8 +++++++-
cad/veriwell/Makefile | 11 ++++++++++-
comms/estic/Makefile | 9 ++++++++-
comms/gsmlib/Makefile | 9 ++++++++-
devel/gcvs/Makefile | 10 +++++++++-
devel/mcpp/Makefile | 8 +++++++-
devel/prcs/Makefile | 12 +++++++++++-
devel/sdcc/Makefile | 8 +++++++-
devel/sgb/Makefile | 8 +++++++-
devel/tvision/Makefile | 9 ++++++++-
editors/em/Makefile | 9 ++++++++-
editors/emacs20/Makefile | 9 ++++++++-
editors/se/Makefile | 8 +++++++-
filesystems/fuse-afpfs-ng/Makefile | 9 ++++++++-
games/devilutionx/Makefile | 9 ++++++++-
games/eboard/Makefile | 11 ++++++++++-
games/golddig/Makefile | 9 ++++++++-
games/libretro-craft/Makefile | 8 +++++++-
games/libretro-nxengine/Makefile | 8 +++++++-
games/scid/Makefile | 8 +++++++-
games/supertuxkart/Makefile | 9 ++++++++-
games/xevil/Makefile | 9 ++++++++-
games/xnibbles/Makefile | 8 +++++++-
games/xye/Makefile | 9 ++++++++-
graphics/libraw/Makefile | 8 +++++++-
graphics/xfig/Makefile | 8 +++++++-
lang/objc/Makefile | 8 +++++++-
mail/mush/Makefile | 8 +++++++-
mail/pine/Makefile | 8 +++++++-
misc/hanzim/Makefile | 9 ++++++++-
multimedia/libmediainfo/Makefile | 8 +++++++-
multimedia/libmp4v2/Makefile | 8 +++++++-
multimedia/openquicktime/Makefile | 8 +++++++-
net/openag/Makefile | 9 ++++++++-
news/nn/Makefile | 8 +++++++-
security/p5-Digest-Hashcash/Makefile | 8 +++++++-
shells/scponly/Makefile | 8 +++++++-
sysutils/fs-kit/Makefile | 9 ++++++++-
sysutils/hal/Makefile | 8 +++++++-
sysutils/xnc/Makefile | 8 +++++++-
sysutils/xps/Makefile | 8 +++++++-
textproc/isearch/Makefile | 8 +++++++-
textproc/lq-sp/Makefile | 9 ++++++++-
www/htdig/Makefile | 9 ++++++++-
x11/fltk/Makefile | 10 +++++++++-
x11/wxGTK28-contrib/Makefile | 9 ++++++++-
x11/wxGTK30/Makefile | 9 ++++++++-
52 files changed, 403 insertions(+), 52 deletions(-)
diffs (truncated from 1172 to 300 lines):
diff -r ab0518b86a2d -r 39fb6f0f5d67 audio/goom/Makefile
--- a/audio/goom/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/audio/goom/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.12 2020/01/26 17:30:42 rillig Exp $
+# $NetBSD: Makefile,v 1.13 2020/05/20 06:09:04 rillig Exp $
DISTNAME= goom-2k4-0-src
PKGNAME= goom-2004.0
@@ -18,5 +18,12 @@
GCC_REQD+= 3.3
USE_TOOLS+= pkg-config
+# convolve_fx.c: In function 'create_output_with_brightness':
+# convolve_fx.c:222:20: error: array subscript has type 'char' [-Werror=char-subscripts]
+# iff2 = ifftab[data->conv_motif[(ytex >>16) & CONV_MOTIF_WMASK][(xtex >> 16) & CONV_MOTIF_WMASK]];
+# ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
.include "../../mk/pthread.buildlink3.mk"
.include "../../mk/bsd.pkg.mk"
diff -r ab0518b86a2d -r 39fb6f0f5d67 audio/mpegaudio/Makefile
--- a/audio/mpegaudio/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/audio/mpegaudio/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.9 2015/12/29 04:54:35 dholland Exp $
+# $NetBSD: Makefile,v 1.10 2020/05/20 06:09:06 rillig Exp $
DISTNAME= mpegaudio
PKGNAME= mpegaudio-3.9
@@ -11,6 +11,16 @@
INSTALLATION_DIRS+= bin ${PKGMANDIR}/man1
+# common.c: In function 'aiff_read_headers':
+# common.c:729:28: error: array subscript has type 'char' [-Werror=char-subscripts]
+# temp_sampleRate[i] = CommChunk.sampleRate[i];
+# ^
+# common.c:729:54: error: array subscript has type 'char' [-Werror=char-subscripts]
+# temp_sampleRate[i] = CommChunk.sampleRate[i];
+# ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
post-install:
${INSTALL_MAN} ${FILESDIR}/mpeg_musicin.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
${INSTALL_MAN} ${FILESDIR}/mpeg_musicout.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
diff -r ab0518b86a2d -r 39fb6f0f5d67 biology/lucy/Makefile
--- a/biology/lucy/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/biology/lucy/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.11 2020/01/26 05:26:15 rillig Exp $
+# $NetBSD: Makefile,v 1.12 2020/05/20 06:09:06 rillig Exp $
#
DISTNAME= ${PKGNAME:S/-//}
@@ -16,6 +16,13 @@
AUTO_MKDIRS= yes
PTHREAD_AUTO_VARS= yes
+# abi.c: In function 'abi_align':
+# abi.c:195:16: error: array subscript has type 'char' [-Werror=char-subscripts]
+# if (badness[a[i]][b[j]]) {
+# ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
do-install:
${INSTALL_PROGRAM} ${WRKSRC}/lucy ${DESTDIR}${PREFIX}/bin
${INSTALL_MAN} ${WRKSRC}/lucy.1 ${DESTDIR}${PREFIX}/${PKGMANDIR}/man1
diff -r ab0518b86a2d -r 39fb6f0f5d67 cad/fasthenry/Makefile
--- a/cad/fasthenry/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/cad/fasthenry/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.31 2020/01/26 17:30:47 rillig Exp $
+# $NetBSD: Makefile,v 1.32 2020/05/20 06:09:03 rillig Exp $
#
DISTNAME= fasthenry-3.0-12Nov96
@@ -36,6 +36,13 @@
GCC_REQD+= 2.95.3
.endif
+# contact.c: In function 'walk_along_edge':
+# contact.c:1334:40: error: array subscript has type 'char' [-Werror=char-subscripts]
+# equiv_nodes_on_edge(cell->bndry.nodes[start_node], travel_dir,
+# ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
INSTALLATION_DIRS= bin
.include "../../mk/bsd.pkg.mk"
diff -r ab0518b86a2d -r 39fb6f0f5d67 cad/magic/Makefile
--- a/cad/magic/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/cad/magic/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.35 2019/06/08 11:04:29 rillig Exp $
+# $NetBSD: Makefile,v 1.36 2020/05/20 06:09:06 rillig Exp $
#
DISTNAME= magic-7.5.188
@@ -34,6 +34,12 @@
CPPFLAGS+= -DIS_LITTLE_ENDIAN
.endif
+# DBundo.c: In function 'dbUndoPaintForw':
+# DBundo.c:268:42: error: array subscript has type 'char' [-Werror=char-subscripts]
+# DBNMPaintPlane(dbUndoLastCell->cd_planes[up->pue_plane],
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
USE_TOOLS+= awk:run
REPLACE_INTERPRETER+= awk
REPLACE.awk.old= /bin/awk
diff -r ab0518b86a2d -r 39fb6f0f5d67 cad/spice/Makefile
--- a/cad/spice/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/cad/spice/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.48 2019/06/08 11:04:30 rillig Exp $
+# $NetBSD: Makefile,v 1.49 2020/05/20 06:09:08 rillig Exp $
DISTNAME= sp3f4.kit
PKGNAME= spice-3f5.1
@@ -42,6 +42,12 @@
SUBST_FILES.conf= conf/NetBSD conf/defaults
SUBST_VARS.conf= MAKE_PROGRAM CFLAGS LDFLAGS WRKSRC PREFIX X11BASE
+# src/lib/cp//modify.c: In function 'cp_init':
+# src/lib/cp//modify.c:26:17: error: array subscript has type 'char' [-Werror=char-subscripts]
+# cp_chars[*s] = (CPC_BRR | CPC_BRL);
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
do-configure:
rm -f ${WRKSRC}/makefile
diff -r ab0518b86a2d -r 39fb6f0f5d67 cad/veriwell/Makefile
--- a/cad/veriwell/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/cad/veriwell/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.2 2020/03/18 17:45:25 joerg Exp $
+# $NetBSD: Makefile,v 1.3 2020/05/20 06:09:09 rillig Exp $
DISTNAME= veriwell-2.8.7
CATEGORIES= cad
@@ -14,5 +14,14 @@
TEST_TARGET= check
+# parse.yy:2253:57: error: array subscript has type 'char' [-Werror=char-subscripts]
+# parse.yy:2253:85: error: array subscript has type 'char' [-Werror=char-subscripts]
+# $$ = edge_mask[$1[0]][$1[1]];
+# parse.yy:2258:79: error: array subscript has type 'char' [-Werror=char-subscripts]
+# parse.yy:2258:108: error: array subscript has type 'char' [-Werror=char-subscripts]
+# $$ = $3 | edge_mask[$1[0]][$1[1]];
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
.include "../../devel/zlib/buildlink3.mk"
.include "../../mk/bsd.pkg.mk"
diff -r ab0518b86a2d -r 39fb6f0f5d67 comms/estic/Makefile
--- a/comms/estic/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/comms/estic/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.38 2019/11/03 12:04:12 rillig Exp $
+# $NetBSD: Makefile,v 1.39 2020/05/20 06:09:03 rillig Exp $
DISTNAME= estic-1.61
PKGREVISION= 2
@@ -32,6 +32,13 @@
CPPFLAGS+= -DFREEBSD
.endif
+# str.cc: In function 'String ShowControls(const String&, unsigned int)':
+# str.cc:1145:57: error: array subscript has type 'char' [-Werror=char-subscripts]
+# T += (Style & ccOct)? OctCodes [*Str] : HexCodes [*Str];
+# ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
INSTALLATION_DIRS= bin
post-extract:
diff -r ab0518b86a2d -r 39fb6f0f5d67 comms/gsmlib/Makefile
--- a/comms/gsmlib/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/comms/gsmlib/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.27 2018/07/18 00:06:12 joerg Exp $
+# $NetBSD: Makefile,v 1.28 2020/05/20 06:09:04 rillig Exp $
#
DISTNAME= gsmlib-1.10
@@ -19,6 +19,13 @@
PTHREAD_OPTS+= require
PTHREAD_AUTO_VARS= yes
+# gsm_util.cc: In function 'std::string gsmlib::gsmToLatin1(std::string)':
+# gsm_util.cc:107:72: error: array subscript has type 'char' [-Werror=char-subscripts]
+# result[i] = (unsigned char)s[i] > 127 ? NOP : gsmToLatin1Table[s[i]];
+# ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
.include "../../devel/gettext-lib/buildlink3.mk"
.include "../../mk/pthread.buildlink3.mk"
.include "../../mk/bsd.pkg.mk"
diff -r ab0518b86a2d -r 39fb6f0f5d67 devel/gcvs/Makefile
--- a/devel/gcvs/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/devel/gcvs/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.45 2020/01/26 05:26:23 rillig Exp $
+# $NetBSD: Makefile,v 1.46 2020/05/20 06:09:04 rillig Exp $
DISTNAME= gcvs-1.0
PKGREVISION= 14
@@ -24,6 +24,14 @@
CPPFLAGS+= -DUSE_INTERP_RESULT
+# Uh oh, Pascal-style strings with undefined behavior for length >= 128.
+# ../rf/ustr.h: In member function 'bool UPStr::endsWith(char) const':
+# ../rf/ustr.h:96:75: error: array subscript has type 'char' [-Werror=char-subscripts]
+# inline bool endsWith(char c) const {return str == 0L ? false : str[str[0]] == c;}
+# ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
.include "../../lang/tcl/buildlink3.mk"
.include "../../x11/gtk/buildlink3.mk"
diff -r ab0518b86a2d -r 39fb6f0f5d67 devel/mcpp/Makefile
--- a/devel/mcpp/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/devel/mcpp/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.2 2017/09/03 08:53:07 wiz Exp $
+# $NetBSD: Makefile,v 1.3 2020/05/20 06:09:06 rillig Exp $
DISTNAME= mcpp-2.7.2
CATEGORIES= devel
@@ -15,4 +15,10 @@
CONFIGURE_ARGS+= --enable-mcpplib
+# eval.c: In function 'eval_if':
+# eval.c:361:44: error: array subscript has type 'char' [-Werror=char-subscripts]
+# , opname[ op], prec, opname[ opp->op], opp->prec, opp->skip);
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
.include "../../mk/bsd.pkg.mk"
diff -r ab0518b86a2d -r 39fb6f0f5d67 devel/prcs/Makefile
--- a/devel/prcs/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/devel/prcs/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.60 2020/03/20 11:57:30 nia Exp $
+# $NetBSD: Makefile,v 1.61 2020/05/20 06:09:07 rillig Exp $
DISTNAME= prcs-1.3.3
PKGREVISION= 14
@@ -28,4 +28,14 @@
REPLACE.perl5.new= ${PERL5}
REPLACE_FILES.perl5= emacs/prcs-ediff emacs/prcs-emerge
+# attrs.cc: In function 'int is_file_attribute_hash(const char*, int)':
+# attrs.cc:36:39: error: array subscript has type 'char' [-Werror=char-subscripts]
+# return len + hash_table[str[len - 1]] + hash_table[str[0]];
+# ^
+# attrs.cc:36:60: error: array subscript has type 'char' [-Werror=char-subscripts]
+# return len + hash_table[str[len - 1]] + hash_table[str[0]];
+# ^
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
.include "../../mk/bsd.pkg.mk"
diff -r ab0518b86a2d -r 39fb6f0f5d67 devel/sdcc/Makefile
--- a/devel/sdcc/Makefile Wed May 20 06:05:37 2020 +0000
+++ b/devel/sdcc/Makefile Wed May 20 06:09:03 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.57 2020/03/20 11:57:32 nia Exp $
+# $NetBSD: Makefile,v 1.58 2020/05/20 06:09:08 rillig Exp $
DISTNAME= sdcc-src-2.8.0
PKGNAME= ${DISTNAME:S/-src//}
@@ -38,6 +38,12 @@
CONFIGURE_ENV+= MACHINE_ARCH=${MACHINE_ARCH:Q}
CONFIGURE_ENV+= sdcc_cv_CCggdb="no"
+# simi.c: In function 'simGetValue':
+# simi.c:616:14: error: array subscript has type 'char' [-Werror=char-subscripts]
+# b[i] = strtol(resp,&resp,16);
+# Maybe fix this later.
+BUILDLINK_TRANSFORM+= rm:-Werror=char-subscripts
+
.include "../../mk/bsd.prefs.mk"
.if ${OPSYS} == "NetBSD"
diff -r ab0518b86a2d -r 39fb6f0f5d67 devel/sgb/Makefile
--- a/devel/sgb/Makefile Wed May 20 06:05:37 2020 +0000
Home |
Main Index |
Thread Index |
Old Index