[pkgsrc/trunk]: pkgsrc/lang/rust lang/rust: Fix MAKE_JOBS_SAFE setting for Ne...

[gdt <gdt%pkgsrc.org@localhost>]

details:   https://anonhg.NetBSD.org/pkgsrc/rev/81ebfe23cf51
branches:  trunk
changeset: 434235:81ebfe23cf51
user:      gdt <gdt%pkgsrc.org@localhost>
date:      Sat Jun 13 13:15:44 2020 +0000

description:
lang/rust: Fix MAKE_JOBS_SAFE setting for NetBSD

The previous conditional was never true.  Assume that it meant to
apply to NetBSD <= 9 and not apply to current.  Add comments
explaining the reason, with \todo for aspects that are unclear,
partially rescued from CVS history, and partially from tech-pkg
discussion.

diffstat:

 lang/rust/Makefile |  15 ++++++++++++---
 1 files changed, 12 insertions(+), 3 deletions(-)

diffs (31 lines):

diff -r 33655e5da3f7 -r 81ebfe23cf51 lang/rust/Makefile
--- a/lang/rust/Makefile        Sat Jun 13 13:02:09 2020 +0000
+++ b/lang/rust/Makefile        Sat Jun 13 13:15:44 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.174 2020/06/09 15:08:24 jperkin Exp $
+# $NetBSD: Makefile,v 1.175 2020/06/13 13:15:44 gdt Exp $
 
 DISTNAME=      rustc-1.43.1-src
 PKGNAME=       ${DISTNAME:S/rustc/rust/:S/-src//}
@@ -136,10 +136,19 @@
 CONFIGURE_ARGS+=       --set llvm.targets="ARM;X86"
 .endif
 
-.if ${OPSYS} == "NetBSD" && !empty(MACHINE_PLATFORM:MNetBSD-9.99.*) && \
-    !empty(MACHINE_PLATFORM:MNetBSD-[1-9][0-9].*)
+.if ${OPSYS} == "NetBSD"
+# On older versions of NetBSD, parallel builds cause problems.
+# \todo Explain if the build is believed to be sound if not parallel,
+# or if a non-parallel build is merely more likely to work.
+# See toolchain/54192 at
+# http://gnats.netbsd.org/cgi-bin/query-pr-single.pl?number=54192
+# \todo Explain if this has been pulled up to 8 and 9, and 
+
+# If we aren't on 9-current, and are on 8.x or 9.x, avoid parallel.
+.if empty(MACHINE_PLATFORM:MNetBSD-9.99.*) && !empty(MACHINE_PLATFORM:MNetBSD-[1-9].*)
 MAKE_JOBS_SAFE=        no
 .endif
+.endif
 
 #
 # Under NetBSD, do not use DT_RUNPATH