Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/ic mark ahc_loadseq()/ahd_loadseq() as __noinline to...



details:   https://anonhg.NetBSD.org/src/rev/da7960ab52d4
branches:  trunk
changeset: 935191:da7960ab52d4
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Sat Jun 27 09:03:15 2020 +0000

description:
mark ahc_loadseq()/ahd_loadseq() as __noinline to avoid 'stack usage
might get unbounded' - seems the variable-length array using const variable
is misinterpreted as unbounded when inlined

diffstat:

 sys/dev/ic/aic79xx.c |  6 +++---
 sys/dev/ic/aic7xxx.c |  8 ++++----
 2 files changed, 7 insertions(+), 7 deletions(-)

diffs (63 lines):

diff -r b5331ec57960 -r da7960ab52d4 sys/dev/ic/aic79xx.c
--- a/sys/dev/ic/aic79xx.c      Sat Jun 27 08:50:46 2020 +0000
+++ b/sys/dev/ic/aic79xx.c      Sat Jun 27 09:03:15 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: aic79xx.c,v 1.53 2019/12/27 09:45:26 msaitoh Exp $     */
+/*     $NetBSD: aic79xx.c,v 1.54 2020/06/27 09:03:15 jdolecek Exp $    */
 
 /*
  * Core routines and tables shareable across OS platforms.
@@ -49,7 +49,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: aic79xx.c,v 1.53 2019/12/27 09:45:26 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: aic79xx.c,v 1.54 2020/06/27 09:03:15 jdolecek Exp $");
 
 #include <dev/ic/aic79xx_osm.h>
 #include <dev/ic/aic79xx_inline.h>
@@ -8252,7 +8252,7 @@
 }
 #endif
 
-static void
+static void __noinline
 ahd_loadseq(struct ahd_softc *ahd)
 {
        struct  cs cs_table[num_critical_sections];
diff -r b5331ec57960 -r da7960ab52d4 sys/dev/ic/aic7xxx.c
--- a/sys/dev/ic/aic7xxx.c      Sat Jun 27 08:50:46 2020 +0000
+++ b/sys/dev/ic/aic7xxx.c      Sat Jun 27 09:03:15 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: aic7xxx.c,v 1.139 2019/12/27 09:45:26 msaitoh Exp $    */
+/*     $NetBSD: aic7xxx.c,v 1.140 2020/06/27 09:03:15 jdolecek Exp $   */
 
 /*
  * Core routines and tables shareable across OS platforms.
@@ -39,7 +39,7 @@
  * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGES.
  *
- * $Id: aic7xxx.c,v 1.139 2019/12/27 09:45:26 msaitoh Exp $
+ * $Id: aic7xxx.c,v 1.140 2020/06/27 09:03:15 jdolecek Exp $
  *
  * //depot/aic7xxx/aic7xxx/aic7xxx.c#112 $
  *
@@ -50,7 +50,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: aic7xxx.c,v 1.139 2019/12/27 09:45:26 msaitoh Exp $");
+__KERNEL_RCSID(0, "$NetBSD: aic7xxx.c,v 1.140 2020/06/27 09:03:15 jdolecek Exp $");
 
 #include <dev/ic/aic7xxx_osm.h>
 #include <dev/ic/aic7xxx_inline.h>
@@ -6275,7 +6275,7 @@
 }
 #endif
 
-static void
+static void __noinline
 ahc_loadseq(struct ahc_softc *ahc)
 {
        struct  cs cs_table[num_critical_sections];



Home | Main Index | Thread Index | Old Index