Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[pkgsrc/trunk]: pkgsrc show-all: fix typo in variable name



details:   https://anonhg.NetBSD.org/pkgsrc/rev/2c0325fc4a2d
branches:  trunk
changeset: 435134:2c0325fc4a2d
user:      rillig <rillig%pkgsrc.org@localhost>
date:      Wed Jul 01 09:13:12 2020 +0000

description:
show-all: fix typo in variable name

The width only applies to a single group, not to several or even all
groups.

diffstat:

 mk/buildlink3/bsd.buildlink3.mk     |   4 ++--
 mk/misc/show.mk                     |   4 ++--
 regress/infra-unittests/show-all.sh |  12 +++++++-----
 3 files changed, 11 insertions(+), 9 deletions(-)

diffs (75 lines):

diff -r d64a8d6da9d2 -r 2c0325fc4a2d mk/buildlink3/bsd.buildlink3.mk
--- a/mk/buildlink3/bsd.buildlink3.mk   Wed Jul 01 09:10:11 2020 +0000
+++ b/mk/buildlink3/bsd.buildlink3.mk   Wed Jul 01 09:13:12 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: bsd.buildlink3.mk,v 1.245 2020/07/01 07:39:52 rillig Exp $
+# $NetBSD: bsd.buildlink3.mk,v 1.246 2020/07/01 09:13:13 rillig Exp $
 #
 # Copyright (c) 2004 The NetBSD Foundation, Inc.
 # All rights reserved.
@@ -204,7 +204,7 @@
 .endfor
 
 _VARGROUPS+=           bl3
-_VARGROUPS_WIDTH.bl3=  39
+_VARGROUP_WIDTH.bl3=   39
 _DEF_VARS.bl3+=                _BLNK_PACKAGES _BLNK_DEPENDS
 _LISTED_VARS.bl3+=     _BLNK_PACKAGES _BLNK_DEPENDS
 .for v in BINDIR CFLAGS CPPFLAGS DEPENDS LDADD LDFLAGS LIBS
diff -r d64a8d6da9d2 -r 2c0325fc4a2d mk/misc/show.mk
--- a/mk/misc/show.mk   Wed Jul 01 09:10:11 2020 +0000
+++ b/mk/misc/show.mk   Wed Jul 01 09:13:12 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: show.mk,v 1.21 2020/07/01 07:39:52 rillig Exp $
+# $NetBSD: show.mk,v 1.22 2020/07/01 09:13:12 rillig Exp $
 #
 # This file contains some targets that print information gathered from
 # variables. They do not modify any variables.
@@ -154,7 +154,7 @@
 
 show-all: .PHONY
 .for g in ${"${.TARGETS:Mshow-all*}":?${_VARGROUPS:O:u}:}
-.  for w in ${_VARGROUPS_WIDTH.${g}:U23}
+.  for w in ${_VARGROUP_WIDTH.${g}:U23}
 
 show-all: show-all-${g}
 
diff -r d64a8d6da9d2 -r 2c0325fc4a2d regress/infra-unittests/show-all.sh
--- a/regress/infra-unittests/show-all.sh       Wed Jul 01 09:10:11 2020 +0000
+++ b/regress/infra-unittests/show-all.sh       Wed Jul 01 09:13:12 2020 +0000
@@ -1,5 +1,5 @@
 #! /bin/sh
-# $NetBSD: show-all.sh,v 1.2 2020/07/01 09:10:11 rillig Exp $
+# $NetBSD: show-all.sh,v 1.3 2020/07/01 09:13:12 rillig Exp $
 #
 # Tests for the show-all target from mk/misc/show.mk.
 #
@@ -168,7 +168,7 @@
 VAR_ARGS=              value1 value2
 
 _VARGROUPS+=           var
-_VARGROUPS_WIDTH.var=  15
+_VARGROUP_WIDTH.var=   15
 _PKG_VARS.var=         VAR_PLAIN VAR_PLAIN_LONG_NAME
 _PKG_VARS.var+=                VAR_ENV VAR_ENV_LONG_NAME
 _PKG_VARS.var+=                VAR_ARGS VAR_ARGS_LONG_NAME
@@ -185,14 +185,16 @@
 
        create_file 'expected' <<'EOF'
 var:
-  pkg   VAR_PLAIN=      "$$var $${var} $$other $$$$"
+  pkg   VAR_PLAIN=      value
   pkg   VAR_PLAIN_LONG_NAME # undefined
   pkg   VAR_ENV=        \
-                        "$$var $${var} $$other $$$$" \
+                        value1 \
+                        value2 \
                         # end of VAR_ENV (sorted)
   pkg   VAR_ENV_LONG_NAME # undefined
   pkg   VAR_ARGS=       \
-                        "$$var $${var} $$other $$$$" \
+                        value1 \
+                        value2 \
                         # end of VAR_ARGS
   pkg   VAR_ARGS_LONG_NAME # undefined
 



Home | Main Index | Thread Index | Old Index