[src/trunk]: src/sys/dev/pci disable MSI/MSI-X for time being, it causes inte...

[jdolecek <jdolecek%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/da5ddf1d4b16
branches:  trunk
changeset: 936035:da5ddf1d4b16
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Thu Jul 16 14:44:43 2020 +0000

description:
disable MSI/MSI-X for time being, it causes interrupt timeouts and needs
to be investigated before enabling this again

diffstat:

 sys/dev/pci/if_bnx.c |  13 ++++++++++---
 1 files changed, 10 insertions(+), 3 deletions(-)

diffs (34 lines):

diff -r a973dfda3e17 -r da5ddf1d4b16 sys/dev/pci/if_bnx.c
--- a/sys/dev/pci/if_bnx.c      Thu Jul 16 14:41:04 2020 +0000
+++ b/sys/dev/pci/if_bnx.c      Thu Jul 16 14:44:43 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_bnx.c,v 1.99 2020/07/14 15:37:40 jdolecek Exp $     */
+/*     $NetBSD: if_bnx.c,v 1.100 2020/07/16 14:44:43 jdolecek Exp $    */
 /*     $OpenBSD: if_bnx.c,v 1.101 2013/03/28 17:21:44 brad Exp $       */
 
 /*-
@@ -35,7 +35,7 @@
 #if 0
 __FBSDID("$FreeBSD: src/sys/dev/bce/if_bce.c,v 1.3 2006/04/13 14:12:26 ru Exp $");
 #endif
-__KERNEL_RCSID(0, "$NetBSD: if_bnx.c,v 1.99 2020/07/14 15:37:40 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_bnx.c,v 1.100 2020/07/16 14:44:43 jdolecek Exp $");
 
 /*
  * The following controllers are supported by this driver:
@@ -625,7 +625,14 @@
                return;
        }
 
-       if (pci_intr_alloc(pa, &sc->bnx_ih, NULL, 0)) {
+       /* XXX using MSI-X causes TX timeouts, needs to be debugged */
+       int counts[PCI_INTR_TYPE_SIZE] = {
+               [PCI_INTR_TYPE_INTX] = 1,
+               [PCI_INTR_TYPE_MSI] = 0,
+               [PCI_INTR_TYPE_MSIX] = 0,
+       };
+
+       if (pci_intr_alloc(pa, &sc->bnx_ih, counts, PCI_INTR_TYPE_INTX)) {
                aprint_error_dev(sc->bnx_dev, "couldn't map interrupt\n");
                goto bnx_attach_fail;
        }