Source-Changes-HG archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
[src/trunk]: src/usr.bin/make/unit-tests make(1): remove obsolete comments fr...
details: https://anonhg.NetBSD.org/src/rev/bb806bb7acc8
branches: trunk
changeset: 938759:bb806bb7acc8
user: rillig <rillig%NetBSD.org@localhost>
date: Mon Sep 14 07:13:29 2020 +0000
description:
make(1): remove obsolete comments from tests
diffstat:
usr.bin/make/unit-tests/cond-undef-lint.exp | 8 ++++----
usr.bin/make/unit-tests/cond-undef-lint.mk | 9 +++++----
usr.bin/make/unit-tests/opt-debug-lint.exp | 4 ++--
usr.bin/make/unit-tests/opt-debug-lint.mk | 11 ++++++-----
4 files changed, 17 insertions(+), 15 deletions(-)
diffs (80 lines):
diff -r 11081d9584de -r bb806bb7acc8 usr.bin/make/unit-tests/cond-undef-lint.exp
--- a/usr.bin/make/unit-tests/cond-undef-lint.exp Mon Sep 14 07:04:56 2020 +0000
+++ b/usr.bin/make/unit-tests/cond-undef-lint.exp Mon Sep 14 07:13:29 2020 +0000
@@ -1,7 +1,7 @@
-make: "cond-undef-lint.mk" line 20: Variable "UNDEF" is undefined
-make: "cond-undef-lint.mk" line 35: Variable "UNDEF" is undefined
-make: "cond-undef-lint.mk" line 35: Variable "VAR." is undefined
-make: "cond-undef-lint.mk" line 42: Variable "VAR.defined" is undefined
+make: "cond-undef-lint.mk" line 23: Variable "UNDEF" is undefined
+make: "cond-undef-lint.mk" line 38: Variable "UNDEF" is undefined
+make: "cond-undef-lint.mk" line 38: Variable "VAR." is undefined
+make: "cond-undef-lint.mk" line 45: Variable "VAR.defined" is undefined
make: Fatal errors encountered -- cannot continue
make: stopped in unit-tests
exit status 1
diff -r 11081d9584de -r bb806bb7acc8 usr.bin/make/unit-tests/cond-undef-lint.mk
--- a/usr.bin/make/unit-tests/cond-undef-lint.mk Mon Sep 14 07:04:56 2020 +0000
+++ b/usr.bin/make/unit-tests/cond-undef-lint.mk Mon Sep 14 07:13:29 2020 +0000
@@ -1,10 +1,13 @@
-# $NetBSD: cond-undef-lint.mk,v 1.1 2020/09/14 06:44:50 rillig Exp $
+# $NetBSD: cond-undef-lint.mk,v 1.2 2020/09/14 07:13:29 rillig Exp $
#
# Tests for defined and undefined variables in .if conditions, in lint mode.
#
# As of 2020-09-14, lint mode contains experimental code for printing
# accurate error messages in case of undefined variables, instead of the
# wrong "Malformed condition".
+#
+# See also:
+# opt-debug-lint.mk
.MAKEFLAGS: -dL
@@ -60,9 +63,7 @@
NESTED_DEF= nested-defined
# Since NESTED_UNDEF is not controllable at this point, it must not generate
-# an error message. This condition should generate no error message at all.
-#
-# TODO: Suppress the error message.
+# an error message, and it doesn't do so, since 2020-09-14.
.if !${INDIRECT}
. error
.endif
diff -r 11081d9584de -r bb806bb7acc8 usr.bin/make/unit-tests/opt-debug-lint.exp
--- a/usr.bin/make/unit-tests/opt-debug-lint.exp Mon Sep 14 07:04:56 2020 +0000
+++ b/usr.bin/make/unit-tests/opt-debug-lint.exp Mon Sep 14 07:13:29 2020 +0000
@@ -1,5 +1,5 @@
-make: "opt-debug-lint.mk" line 18: Variable "X" is undefined
-make: "opt-debug-lint.mk" line 40: Variable "UNDEF" is undefined
+make: "opt-debug-lint.mk" line 19: Variable "X" is undefined
+make: "opt-debug-lint.mk" line 41: Variable "UNDEF" is undefined
make: Fatal errors encountered -- cannot continue
make: stopped in unit-tests
exit status 1
diff -r 11081d9584de -r bb806bb7acc8 usr.bin/make/unit-tests/opt-debug-lint.mk
--- a/usr.bin/make/unit-tests/opt-debug-lint.mk Mon Sep 14 07:04:56 2020 +0000
+++ b/usr.bin/make/unit-tests/opt-debug-lint.mk Mon Sep 14 07:13:29 2020 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: opt-debug-lint.mk,v 1.3 2020/09/13 20:21:24 rillig Exp $
+# $NetBSD: opt-debug-lint.mk,v 1.4 2020/09/14 07:13:29 rillig Exp $
#
# Tests for the -dL command line option, which runs additional checks
# to catch common mistakes, such as unclosed variable expressions.
@@ -11,10 +11,11 @@
# misleading. The form of the condition is totally fine, it's the evaluation
# that fails.
#
-# TODO: Get rid of the "Malformed conditional" error message.
-# As long as the first error message is only printed in lint mode, it can
-# get tricky to keep track of the actually printed error messages and those
-# that still need to be printed. That's probably a solvable problem though.
+# Since 2020-09-13, the "Malformed conditional" error message is not printed
+# anymore.
+#
+# See also:
+# cond-undef-lint.mk
.if $X
. error
.endif
Home |
Main Index |
Thread Index |
Old Index