[src/trunk]: src/usr.bin/make make(1): document details on why JobRun runs .E...

[rillig <rillig%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/b98ae547e96d
branches:  trunk
changeset: 944263:b98ae547e96d
user:      rillig <rillig%NetBSD.org@localhost>
date:      Fri Sep 25 06:20:44 2020 +0000

description:
make(1): document details on why JobRun runs .END in compat mode

diffstat:

 usr.bin/make/job.c |  17 ++++++++++-------
 1 files changed, 10 insertions(+), 7 deletions(-)

diffs (40 lines):

diff -r 4fac7e005608 -r b98ae547e96d usr.bin/make/job.c
--- a/usr.bin/make/job.c        Fri Sep 25 06:15:30 2020 +0000
+++ b/usr.bin/make/job.c        Fri Sep 25 06:20:44 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: job.c,v 1.237 2020/09/24 07:11:29 rillig Exp $ */
+/*     $NetBSD: job.c,v 1.238 2020/09/25 06:20:44 rillig Exp $ */
 
 /*
  * Copyright (c) 1988, 1989, 1990 The Regents of the University of California.
@@ -140,7 +140,7 @@
 #include "trace.h"
 
 /*     "@(#)job.c      8.2 (Berkeley) 3/19/94" */
-MAKE_RCSID("$NetBSD: job.c,v 1.237 2020/09/24 07:11:29 rillig Exp $");
+MAKE_RCSID("$NetBSD: job.c,v 1.238 2020/09/25 06:20:44 rillig Exp $");
 
 # define STATIC static
 
@@ -1907,13 +1907,16 @@
 static void
 JobRun(GNode *targ)
 {
-#ifdef notyet
+#if 0
     /*
-     * Unfortunately it is too complicated to run .BEGIN, .END,
-     * and .INTERRUPT job in the parallel job module. This has
-     * the nice side effect that it avoids a lot of other problems.
+     * Unfortunately it is too complicated to run .BEGIN, .END, and
+     * .INTERRUPT job in the parallel job module.  As of 2020-09-25,
+     * unit-tests/deptgt-end-jobs.mk hangs in an endless loop.
+     *
+     * Running these jobs in compat mode also guarantees that these
+     * jobs do not overlap with other unrelated jobs.
      */
-    Lst lst = Lst_Init();
+    List *lst = Lst_Init();
     Lst_Append(lst, targ);
     (void)Make_Run(lst);
     Lst_Destroy(lst, NULL);