Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci Remove incorrect comment. It would violate the s...



details:   https://anonhg.NetBSD.org/src/rev/93df2bd1c656
branches:  trunk
changeset: 950306:93df2bd1c656
user:      reinoud <reinoud%NetBSD.org@localhost>
date:      Sun Jan 24 15:59:35 2021 +0000

description:
Remove incorrect comment. It would violate the specs.

VirtIO PCI v1.0 attachments can only happen on revision 1 devices as they have
a radical different register layout. Transitional devices have to use revision
0 and have to use the VirtIO PCI v0.9 attachment method but can allow for
features to be negotiated normally found in later versions.

diffstat:

 sys/dev/pci/virtio_pci.c |  10 ++--------
 1 files changed, 2 insertions(+), 8 deletions(-)

diffs (31 lines):

diff -r da7bc9c2b68a -r 93df2bd1c656 sys/dev/pci/virtio_pci.c
--- a/sys/dev/pci/virtio_pci.c  Sun Jan 24 15:43:22 2021 +0000
+++ b/sys/dev/pci/virtio_pci.c  Sun Jan 24 15:59:35 2021 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: virtio_pci.c,v 1.24 2021/01/24 15:34:07 thorpej Exp $ */
+/* $NetBSD: virtio_pci.c,v 1.25 2021/01/24 15:59:35 reinoud Exp $ */
 
 /*
  * Copyright (c) 2020 The NetBSD Foundation, Inc.
@@ -28,7 +28,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: virtio_pci.c,v 1.24 2021/01/24 15:34:07 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: virtio_pci.c,v 1.25 2021/01/24 15:59:35 reinoud Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -461,12 +461,6 @@
        else
                have_device_cfg = 1;
 
-       /*
-        * XXX Maybe there are devices that offer the pci caps but not the
-        * XXX VERSION_1 feature bit? Then we should check the feature bit
-        * XXX here and fall back to 0.9 out if not present.
-        */
-
        /* Figure out which bars we need to map */
        for (i = 0; i < __arraycount(caps); i++) {
                int bar = caps[i]->bar;



Home | Main Index | Thread Index | Old Index