[src/trunk]: src/usr.bin/make/filemon make: document the syscalls that are no...

[rillig <rillig%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/7fa6e42cafad
branches:  trunk
changeset: 959141:7fa6e42cafad
user:      rillig <rillig%NetBSD.org@localhost>
date:      Mon Feb 01 21:34:41 2021 +0000

description:
make: document the syscalls that are not monitored by filemon_ktrace

diffstat:

 usr.bin/make/filemon/filemon_ktrace.c |  11 ++++++++++-
 1 files changed, 10 insertions(+), 1 deletions(-)

diffs (39 lines):

diff -r ad04da7be9ab -r 7fa6e42cafad usr.bin/make/filemon/filemon_ktrace.c
--- a/usr.bin/make/filemon/filemon_ktrace.c     Mon Feb 01 21:32:54 2021 +0000
+++ b/usr.bin/make/filemon/filemon_ktrace.c     Mon Feb 01 21:34:41 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: filemon_ktrace.c,v 1.13 2021/01/19 20:51:46 rillig Exp $       */
+/*     $NetBSD: filemon_ktrace.c,v 1.14 2021/02/01 21:34:41 rillig Exp $       */
 
 /*
  * Copyright (c) 2019 The NetBSD Foundation, Inc.
@@ -761,6 +761,8 @@
        return syscall_enter(key, call, 1, &show_chdir);
 }
 
+/* TODO: monitor fchdir as well */
+
 /*ARGSUSED*/
 static struct filemon_state *
 filemon_sys_execve(struct filemon *F, const struct filemon_key *key,
@@ -832,6 +834,11 @@
        const register_t *args = (const void *)&call[1];
        int flags, fd;
 
+       /*
+        * XXX: In the .meta log, the base directory is missing, which makes
+        * all references to relative pathnames useless.
+        */
+
        if (call->ktr_argsize < 3)
                return NULL;
        fd = (int)args[0];
@@ -860,6 +867,8 @@
        }
 }
 
+/* TODO: monitor the other *at syscalls as well, not only openat. */
+
 /*ARGSUSED*/
 static struct filemon_state *
 filemon_sys_symlink(struct filemon *F, const struct filemon_key *key,