[src/trunk]: src/sys/netinet Don't increment the iss sequence on each connect...

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/5eeb626988a0
branches:  trunk
changeset: 960115:5eeb626988a0
user:      christos <christos%NetBSD.org@localhost>
date:      Mon Mar 08 17:53:20 2021 +0000

description:
Don't increment the iss sequence on each connection because it exposes
information (Amit Klein)

diffstat:

 sys/netinet/tcp_subr.c |  6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diffs (34 lines):

diff -r ad479a8bbdc7 -r 5eeb626988a0 sys/netinet/tcp_subr.c
--- a/sys/netinet/tcp_subr.c    Mon Mar 08 17:34:30 2021 +0000
+++ b/sys/netinet/tcp_subr.c    Mon Mar 08 17:53:20 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: tcp_subr.c,v 1.285 2021/03/07 14:58:54 christos Exp $  */
+/*     $NetBSD: tcp_subr.c,v 1.286 2021/03/08 17:53:20 christos Exp $  */
 
 /*
  * Copyright (C) 1995, 1996, 1997, and 1998 WIDE Project.
@@ -91,7 +91,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: tcp_subr.c,v 1.285 2021/03/07 14:58:54 christos Exp $");
+__KERNEL_RCSID(0, "$NetBSD: tcp_subr.c,v 1.286 2021/03/08 17:53:20 christos Exp $");
 
 #ifdef _KERNEL_OPT
 #include "opt_inet.h"
@@ -2216,7 +2216,6 @@
                 * XXX Use `addin'?
                 * XXX TCP_ISSINCR too large to use?
                 */
-               tcp_iss_seq += TCP_ISSINCR;
 #ifdef TCPISS_DEBUG
                printf("ISS hash 0x%08x, ", tcp_iss);
 #endif
@@ -2252,7 +2251,6 @@
                } else {
                        tcp_iss &= TCP_ISS_RANDOM_MASK;
                        tcp_iss += tcp_iss_seq;
-                       tcp_iss_seq += TCP_ISSINCR;
 #ifdef TCPISS_DEBUG
                        printf("ISS %08x\n", tcp_iss);
 #endif