Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/modules Continue to build the filemon module, but don't ...



details:   https://anonhg.NetBSD.org/src/rev/d1865b21bfdf
branches:  trunk
changeset: 966389:d1865b21bfdf
user:      pgoyette <pgoyette%NetBSD.org@localhost>
date:      Mon Oct 28 16:03:55 2019 +0000

description:
Continue to build the filemon module, but don't install it.  Hopefully
this will help us detect any additional bit-rot that might occur.

XXX It might be a good idea to modify the file permissions on /dev/filemon
XXX to prevent auto-loading of the driver module by non-privileged users.

diffstat:

 sys/modules/Makefile         |  4 ++--
 sys/modules/filemon/Makefile |  8 +++++++-
 2 files changed, 9 insertions(+), 3 deletions(-)

diffs (38 lines):

diff -r 31208fd2e414 -r d1865b21bfdf sys/modules/Makefile
--- a/sys/modules/Makefile      Mon Oct 28 15:42:07 2019 +0000
+++ b/sys/modules/Makefile      Mon Oct 28 16:03:55 2019 +0000
@@ -1,4 +1,4 @@
-#      $NetBSD: Makefile,v 1.229 2019/10/28 13:19:50 maya Exp $
+#      $NetBSD: Makefile,v 1.230 2019/10/28 16:03:55 pgoyette Exp $
 
 .include <bsd.own.mk>
 
@@ -54,7 +54,7 @@
 SUBDIR+=       fdesc
 SUBDIR+=       ffs
 SUBDIR+=       filecore
-#SUBDIR+=      filemon
+SUBDIR+=       filemon
 SUBDIR+=       flash
 SUBDIR+=       fss
 SUBDIR+=       gpio
diff -r 31208fd2e414 -r d1865b21bfdf sys/modules/filemon/Makefile
--- a/sys/modules/filemon/Makefile      Mon Oct 28 15:42:07 2019 +0000
+++ b/sys/modules/filemon/Makefile      Mon Oct 28 16:03:55 2019 +0000
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.3 2019/10/13 07:28:13 mrg Exp $
+# $NetBSD: Makefile,v 1.4 2019/10/28 16:03:55 pgoyette Exp $
 
 .include "../Makefile.inc"
 
@@ -11,4 +11,10 @@
 
 COPTS.filemon_wrapper.c+=      ${GCC_NO_CAST_FUNCTION_TYPE}
 
+# Due to security concerns, we don't install the filemon module.  We
+# do, however, want to keep building it to prevent bit-rot.  Define
+# an empty install target for this.
+
+kmodinstall:
+
 .include <bsd.kmodule.mk>



Home | Main Index | Thread Index | Old Index