Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/nvmm/x86 Mmh, as noted in PR/54847, this should be u...



details:   https://anonhg.NetBSD.org/src/rev/f8e69200ddf1
branches:  trunk
changeset: 968273:f8e69200ddf1
user:      maxv <maxv%NetBSD.org@localhost>
date:      Thu Jan 09 16:20:12 2020 +0000

description:
Mmh, as noted in PR/54847, this should be uint64_t, not uint16_t. Harmless
because we use only the two lowest bits anyway.

I believe this could be caught by KUBSAN; time to do another round of
NVMM+K_SAN testing.

diffstat:

 sys/dev/nvmm/x86/nvmm_x86_vmx.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r aa44b6d1ec39 -r f8e69200ddf1 sys/dev/nvmm/x86/nvmm_x86_vmx.c
--- a/sys/dev/nvmm/x86/nvmm_x86_vmx.c   Thu Jan 09 15:50:16 2020 +0000
+++ b/sys/dev/nvmm/x86/nvmm_x86_vmx.c   Thu Jan 09 16:20:12 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: nvmm_x86_vmx.c,v 1.46 2019/12/10 18:06:50 ad Exp $     */
+/*     $NetBSD: nvmm_x86_vmx.c,v 1.47 2020/01/09 16:20:12 maxv Exp $   */
 
 /*
  * Copyright (c) 2018-2019 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: nvmm_x86_vmx.c,v 1.46 2019/12/10 18:06:50 ad Exp $");
+__KERNEL_RCSID(0, "$NetBSD: nvmm_x86_vmx.c,v 1.47 2020/01/09 16:20:12 maxv Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -1688,7 +1688,7 @@
     struct nvmm_vcpu_exit *exit)
 {
        struct vmx_cpudata *cpudata = vcpu->cpudata;
-       uint16_t val;
+       uint64_t val;
 
        exit->reason = NVMM_VCPU_EXIT_NONE;
 



Home | Main Index | Thread Index | Old Index