[src/trunk]: src/sys/dev/pci/ixgbe Simplify SFP+ check. No functional change.

[msaitoh <msaitoh%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/cfe42c42f637
branches:  trunk
changeset: 974942:cfe42c42f637
user:      msaitoh <msaitoh%NetBSD.org@localhost>
date:      Mon Aug 17 08:23:30 2020 +0000

description:
Simplify SFP+ check. No functional change.

diffstat:

 sys/dev/pci/ixgbe/ixgbe.c |  14 ++++++--------
 1 files changed, 6 insertions(+), 8 deletions(-)

diffs (35 lines):

diff -r edd12d0b291d -r cfe42c42f637 sys/dev/pci/ixgbe/ixgbe.c
--- a/sys/dev/pci/ixgbe/ixgbe.c Mon Aug 17 07:59:06 2020 +0000
+++ b/sys/dev/pci/ixgbe/ixgbe.c Mon Aug 17 08:23:30 2020 +0000
@@ -1,4 +1,4 @@
-/* $NetBSD: ixgbe.c,v 1.238 2020/08/17 07:59:06 msaitoh Exp $ */
+/* $NetBSD: ixgbe.c,v 1.239 2020/08/17 08:23:30 msaitoh Exp $ */
 
 /******************************************************************************
 
@@ -4465,7 +4465,6 @@
        u64             v0, v1, v2, v3, v4, v5, v6, v7;
        int             hung = 0;
        int             i;
-       bool            do_probe = false;
 
        IXGBE_CORE_LOCK(adapter);
 
@@ -4475,12 +4474,11 @@
                bool is_full = ixgbe_sfp_cage_full(hw);
 
                /* do probe if cage state changed */
-               if (was_full ^ is_full)
-                       do_probe = true;
-       }
-       if (do_probe) {
-               atomic_or_32(&adapter->task_requests, IXGBE_REQUEST_TASK_MOD);
-               ixgbe_schedule_admin_tasklet(adapter);
+               if (was_full ^ is_full) {
+                       atomic_or_32(&adapter->task_requests,
+                           IXGBE_REQUEST_TASK_MOD);
+                       ixgbe_schedule_admin_tasklet(adapter);
+               }
        }
 
        ixgbe_update_link_status(adapter);