Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.bin/make make(1): consistently access args->pflags in Mo...



details:   https://anonhg.NetBSD.org/src/rev/3e0fbd34da56
branches:  trunk
changeset: 975000:3e0fbd34da56
user:      rillig <rillig%NetBSD.org@localhost>
date:      Thu Aug 20 06:48:18 2020 +0000

description:
make(1): consistently access args->pflags in ModifyWord_Subst

It was confusing that some accesses were via pflags and some via
args->pflags.

diffstat:

 usr.bin/make/var.c |  9 ++++-----
 1 files changed, 4 insertions(+), 5 deletions(-)

diffs (38 lines):

diff -r acad3e3ee362 -r 3e0fbd34da56 usr.bin/make/var.c
--- a/usr.bin/make/var.c        Thu Aug 20 06:35:14 2020 +0000
+++ b/usr.bin/make/var.c        Thu Aug 20 06:48:18 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: var.c,v 1.450 2020/08/20 06:35:14 rillig Exp $ */
+/*     $NetBSD: var.c,v 1.451 2020/08/20 06:48:18 rillig Exp $ */
 
 /*
  * Copyright (c) 1988, 1989, 1990, 1993
@@ -69,14 +69,14 @@
  */
 
 #ifndef MAKE_NATIVE
-static char rcsid[] = "$NetBSD: var.c,v 1.450 2020/08/20 06:35:14 rillig Exp $";
+static char rcsid[] = "$NetBSD: var.c,v 1.451 2020/08/20 06:48:18 rillig Exp $";
 #else
 #include <sys/cdefs.h>
 #ifndef lint
 #if 0
 static char sccsid[] = "@(#)var.c      8.3 (Berkeley) 3/19/94";
 #else
-__RCSID("$NetBSD: var.c,v 1.450 2020/08/20 06:35:14 rillig Exp $");
+__RCSID("$NetBSD: var.c,v 1.451 2020/08/20 06:48:18 rillig Exp $");
 #endif
 #endif /* not lint */
 #endif
@@ -1278,10 +1278,9 @@
 {
     size_t wordLen = strlen(word);
     ModifyWord_SubstArgs *args = data;
-    const VarPatternFlags pflags = args->pflags;
     const char *match;
 
-    if ((pflags & VARP_SUB_ONE) && (pflags & VARP_SUB_MATCHED))
+    if ((args->pflags & VARP_SUB_ONE) && (args->pflags & VARP_SUB_MATCHED))
        goto nosub;
 
     if (args->pflags & VARP_ANCHOR_START) {



Home | Main Index | Thread Index | Old Index