Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/usr.bin/make make(1): remove useless comment from TargFreeGN



details:   https://anonhg.NetBSD.org/src/rev/6ed4e46cfa90
branches:  trunk
changeset: 976539:6ed4e46cfa90
user:      rillig <rillig%NetBSD.org@localhost>
date:      Sat Sep 26 16:21:17 2020 +0000

description:
make(1): remove useless comment from TargFreeGN

GNode.fname is a const char *, therefore it cannot be freed anyway.

diffstat:

 usr.bin/make/targ.c |  6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diffs (34 lines):

diff -r 0e3336e40a2c -r 6ed4e46cfa90 usr.bin/make/targ.c
--- a/usr.bin/make/targ.c       Sat Sep 26 16:18:44 2020 +0000
+++ b/usr.bin/make/targ.c       Sat Sep 26 16:21:17 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: targ.c,v 1.96 2020/09/26 16:18:44 rillig Exp $ */
+/*     $NetBSD: targ.c,v 1.97 2020/09/26 16:21:17 rillig Exp $ */
 
 /*
  * Copyright (c) 1988, 1989, 1990, 1993
@@ -119,7 +119,7 @@
 #include         "dir.h"
 
 /*     "@(#)targ.c     8.2 (Berkeley) 3/19/94" */
-MAKE_RCSID("$NetBSD: targ.c,v 1.96 2020/09/26 16:18:44 rillig Exp $");
+MAKE_RCSID("$NetBSD: targ.c,v 1.97 2020/09/26 16:21:17 rillig Exp $");
 
 static GNodeList *allTargets;  /* the list of all targets found so far */
 #ifdef CLEANUP
@@ -230,7 +230,6 @@
     Lst_Free(gn->commands);
 
     /* XXX: does gn->suffix need to be freed? It is reference-counted. */
-    /* gn->fname points to name allocated when file was opened, don't free */
 
     free(gn);
 }
@@ -247,7 +246,6 @@
 GNode *
 Targ_GetNode(const char *name)
 {
-
     Boolean isNew;
     Hash_Entry *he = Hash_CreateEntry(&targets, name, &isNew);
     if (!isNew)



Home | Main Index | Thread Index | Old Index