[xsrc/trunk]: xsrc/external/mit/libXaw/dist/src make this compile again under...

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/xsrc/rev/3a7748c1877e
branches:  trunk
changeset: 10714:3a7748c1877e
user:      christos <christos%NetBSD.org@localhost>
date:      Sun May 09 16:58:19 2021 +0000

description:
make this compile again under clang:
- factor out duplicated code
- add casts
- plug memory leak

diffstat:

 external/mit/libXaw/dist/src/Pixmap.c |  80 +++++++++++++++-------------------
 1 files changed, 36 insertions(+), 44 deletions(-)

diffs (147 lines):

diff -r 93786f6510b4 -r 3a7748c1877e external/mit/libXaw/dist/src/Pixmap.c
--- a/external/mit/libXaw/dist/src/Pixmap.c     Sun May 09 16:55:36 2021 +0000
+++ b/external/mit/libXaw/dist/src/Pixmap.c     Sun May 09 16:58:19 2021 +0000
@@ -699,6 +699,27 @@
        pixmap_path = default_path;
 }
 
+static const char *
+GetFileName(XawParams *params, Screen *screen)
+{
+  static SubstitutionRec sub[] = {
+    {'H',   NULL},
+    {'N',   NULL},
+    {'T',   "pixmaps"},
+    {'P',   PROJECT_ROOT},
+  };
+  if (params->name[0] != '/' && params->name[0] != '.')
+    {
+      if (!sub[0].substitution)
+       sub[0].substitution = getenv("HOME");
+      sub[1].substitution = (char *)params->name;
+      if (pixmap_path == NULL)
+       GetResourcePixmapPath(DisplayOfScreen(screen));
+      return XtFindFile(pixmap_path, sub, XtNumber(sub), NULL);
+    }
+   return params->name;
+}
+
 static Bool
 BitmapLoader(XawParams *params, Screen *screen, Colormap colormap, int depth,
             Pixmap *pixmap_return, Pixmap *mask_return,
@@ -712,13 +733,7 @@
   int hotX, hotY;
   XawArgVal *argval;
   Bool retval = False;
-  static SubstitutionRec sub[] = {
-    {'H',   NULL},
-    {'N',   NULL},
-    {'T',   "bitmaps"},
-    {'P',   PROJECT_ROOT},
-  };
-  char *filename;
+  const char *filename;
 
   fg = BlackPixelOfScreen(screen);
   bg = WhitePixelOfScreen(screen);
@@ -742,19 +757,9 @@
        return (False);
     }
 
-  if (params->name[0] != '/' && params->name[0] != '.')
-    {
-      if (!sub[0].substitution)
-       sub[0].substitution = getenv("HOME");
-      sub[1].substitution = params->name;
-      if (pixmap_path == NULL)
-       GetResourcePixmapPath(DisplayOfScreen(screen));
-      filename = XtFindFile(pixmap_path, sub, XtNumber(sub), NULL);
-      if (!filename)
-       return (FALSE);
-    }
-  else
-    filename = params->name;
+  filename = GetFileName(params, screen);
+  if (!filename)
+    return (FALSE);
 
   if (XReadBitmapFileData(filename, &width, &height, &data,
                          &hotX, &hotY) == BitmapSuccess)
@@ -774,7 +779,7 @@
     }
 
   if (filename != params->name)
-    XtFree(filename);
+    XtFree((char *)filename);
 
   return (retval);
 }
@@ -827,7 +832,7 @@
 
   value = NULL;
   if ((argval = XawFindArgVal(params, "start")) != NULL)
-    value = argval->value;
+    value = (char *)argval->value;
   if (value && !XAllocNamedColor(DisplayOfScreen(screen), colormap, value,
                            &start, &color))
     return (False);
@@ -838,7 +843,7 @@
     }
   value = NULL;
   if ((argval = XawFindArgVal(params, "end")) != NULL)
-    value = argval->value;
+    value = (char *)argval->value;
   if (value && !XAllocNamedColor(DisplayOfScreen(screen), colormap, value,
                            &end, &color))
     return (False);
@@ -932,31 +937,16 @@
   XpmAttributes xpm_attributes;
   XawArgVal *argval;
   unsigned int closeness = 4000;
-  static SubstitutionRec sub[] = {
-    {'H',   NULL},
-    {'N',   NULL},
-    {'T',   "pixmaps"},
-    {'P',   PROJECT_ROOT},
-  };
+  Bool retval = False;
   const char *filename;
 
   if ((argval = XawFindArgVal(params, "closeness")) != NULL
       && argval->value)
     closeness = (unsigned)atoi(argval->value);
 
-  if (params->name[0] != '/' && params->name[0] != '.')
-    {
-      if (!sub[0].substitution)
-       sub[0].substitution = getenv("HOME");
-      sub[1].substitution = params->name;
-      if (pixmap_path == NULL)
-       GetResourcePixmapPath(DisplayOfScreen(screen));
-      filename = XtFindFile(pixmap_path, sub, XtNumber(sub), NULL);
-      if (!filename)
-       return (False);
-    }
-  else
-    filename = params->name;
+  filename = GetFileName(params, screen);
+  if (!filename)
+    return (FALSE);
 
   xpm_attributes.colormap = colormap;
   xpm_attributes.closeness = closeness;
@@ -968,10 +958,12 @@
       *width_return = (Dimension)xpm_attributes.width;
       *height_return = (Dimension)xpm_attributes.height;
 
-      return (True);
+      retval = True;
     }
 
-  return (False);
+  if (filename != params->name)
+    XtFree((char *)filename);
+  return (retval);
 }
 
 void