Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sbin/dump Bitmaps (TS_BITS and TS_CLRI) dont use the "c_addr...



details:   https://anonhg.NetBSD.org/src/rev/4a51336d3a26
branches:  trunk
changeset: 983802:4a51336d3a26
user:      hannken <hannken%NetBSD.org@localhost>
date:      Mon Jun 07 14:07:32 2021 +0000

description:
Bitmaps (TS_BITS and TS_CLRI) dont use the "c_addr" array as they
cannot have holes.  As bitmaps are written without TS_ADDR records
"c_count" may be larger than the "c_addr" size resulting in a
segmentation violation reading "c_addr" beyond its end.

Compute "blks" for TS_INODE and TS_ADDR only -- its used for multi
volume dumps and the bitmaps must both be on the first volume.

diffstat:

 sbin/dump/tape.c |  7 ++++---
 1 files changed, 4 insertions(+), 3 deletions(-)

diffs (28 lines):

diff -r 81752a4ee3dd -r 4a51336d3a26 sbin/dump/tape.c
--- a/sbin/dump/tape.c  Mon Jun 07 11:45:35 2021 +0000
+++ b/sbin/dump/tape.c  Mon Jun 07 14:07:32 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: tape.c,v 1.55 2019/03/01 16:42:11 christos Exp $       */
+/*     $NetBSD: tape.c,v 1.56 2021/06/07 14:07:32 hannken Exp $        */
 
 /*-
  * Copyright (c) 1980, 1991, 1993
@@ -34,7 +34,7 @@
 #if 0
 static char sccsid[] = "@(#)tape.c     8.4 (Berkeley) 5/1/95";
 #else
-__RCSID("$NetBSD: tape.c,v 1.55 2019/03/01 16:42:11 christos Exp $");
+__RCSID("$NetBSD: tape.c,v 1.56 2021/06/07 14:07:32 hannken Exp $");
 #endif
 #endif /* not lint */
 
@@ -328,7 +328,8 @@
        }
 
        blks = 0;
-       if (iswap32(spcl.c_type) != TS_END) {
+       if (iswap32(spcl.c_type) == TS_INODE ||
+           iswap32(spcl.c_type) == TS_ADDR) {
                for (i = 0; i < iswap32(spcl.c_count); i++)
                        if (spcl.c_addr[i] != 0)
                                blks++;



Home | Main Index | Thread Index | Old Index