Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/crypto/external/bsd/openssh/dist Fix inverted logic in OpenS...



details:   https://anonhg.NetBSD.org/src/rev/dd1d12d2d98d
branches:  trunk
changeset: 985671:dd1d12d2d98d
user:      ryoon <ryoon%NetBSD.org@localhost>
date:      Sat Sep 04 01:47:47 2021 +0000

description:
Fix inverted logic in OpenSSH SSHFP DNS record verification

diffstat:

 crypto/external/bsd/openssh/dist/dns.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r d7297c081c17 -r dd1d12d2d98d crypto/external/bsd/openssh/dist/dns.c
--- a/crypto/external/bsd/openssh/dist/dns.c    Sat Sep 04 01:34:32 2021 +0000
+++ b/crypto/external/bsd/openssh/dist/dns.c    Sat Sep 04 01:47:47 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: dns.c,v 1.19 2021/09/02 11:26:17 christos Exp $        */
+/*     $NetBSD: dns.c,v 1.20 2021/09/04 01:47:47 ryoon Exp $   */
 /* $OpenBSD: dns.c,v 1.41 2021/07/19 03:13:28 dtucker Exp $ */
 
 /*
@@ -27,7 +27,7 @@
  */
 
 #include "includes.h"
-__RCSID("$NetBSD: dns.c,v 1.19 2021/09/02 11:26:17 christos Exp $");
+__RCSID("$NetBSD: dns.c,v 1.20 2021/09/04 01:47:47 ryoon Exp $");
 #include <sys/types.h>
 #include <sys/socket.h>
 
@@ -267,7 +267,7 @@
                /* Check if the current key is the same as the given key */
                if (hostkey_algorithm == dnskey_algorithm &&
                    hostkey_digest_len == dnskey_digest_len) {
-                       if (consttime_memequal(hostkey_digest, dnskey_digest,
+                       if (!consttime_memequal(hostkey_digest, dnskey_digest,
                            hostkey_digest_len) == 0) {
                                debug_f("matched SSHFP type %d fptype %d",
                                    dnskey_algorithm, dnskey_digest_type);



Home | Main Index | Thread Index | Old Index