Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/arch/arm/pic Only perform pic_unblock_percpu if all of t...



details:   https://anonhg.NetBSD.org/src/rev/43a24c12d8b6
branches:  trunk
changeset: 990629:43a24c12d8b6
user:      skrll <skrll%NetBSD.org@localhost>
date:      Sun Oct 31 16:29:18 2021 +0000

description:
Only perform pic_unblock_percpu if all of the following are true
- mp_online, i.e. APs are running.
- is_mpsafe, i.e. the interrupt handler is MP safe
- is_percpu, i.e. the interrupt actually requires it!

The last one (is_percpu) is true for GIC PPI+SGI only.

diffstat:

 sys/arch/arm/pic/pic.c |  6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diffs (27 lines):

diff -r f4b2e7a70d99 -r 43a24c12d8b6 sys/arch/arm/pic/pic.c
--- a/sys/arch/arm/pic/pic.c    Sun Oct 31 16:26:26 2021 +0000
+++ b/sys/arch/arm/pic/pic.c    Sun Oct 31 16:29:18 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: pic.c,v 1.74 2021/10/31 16:24:47 skrll Exp $   */
+/*     $NetBSD: pic.c,v 1.75 2021/10/31 16:29:18 skrll Exp $   */
 /*-
  * Copyright (c) 2008 The NetBSD Foundation, Inc.
  * All rights reserved.
@@ -33,7 +33,7 @@
 #include "opt_multiprocessor.h"
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: pic.c,v 1.74 2021/10/31 16:24:47 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: pic.c,v 1.75 2021/10/31 16:29:18 skrll Exp $");
 
 #include <sys/param.h>
 #include <sys/atomic.h>
@@ -792,7 +792,7 @@
        (*pic->pic_ops->pic_establish_irq)(pic, is);
 
 unblock:
-       if (!mp_online || !is->is_mpsafe) {
+       if (!mp_online || !is->is_mpsafe || !is->is_percpu) {
                (*pic->pic_ops->pic_unblock_irqs)(pic, is->is_irq & ~0x1f,
                    __BIT(is->is_irq & 0x1f));
        } else {



Home | Main Index | Thread Index | Old Index