Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/lib/libdm Clean up double free in some error paths that did ...



details:   https://anonhg.NetBSD.org/src/rev/18f1bb15cfb4
branches:  trunk
changeset: 995546:18f1bb15cfb4
user:      mlelstv <mlelstv%NetBSD.org@localhost>
date:      Thu Dec 27 14:05:54 2018 +0000

description:
Clean up double free in some error paths that did trigger
an assertion in libprop.

diffstat:

 lib/libdm/libdm_ioctl.c |  4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diffs (21 lines):

diff -r 5d5ebdb12144 -r 18f1bb15cfb4 lib/libdm/libdm_ioctl.c
--- a/lib/libdm/libdm_ioctl.c   Thu Dec 27 14:03:54 2018 +0000
+++ b/lib/libdm/libdm_ioctl.c   Thu Dec 27 14:05:54 2018 +0000
@@ -165,8 +165,6 @@
 
        error = rump_sys_ioctl(libdm_control_fd, NETBSD_DM_IOCTL, &prefp);
        if (error < 0) {
-               libdm_task_destroy(libdm_task);
-               libdm_task = NULL;
                libdm_control_close(libdm_control_fd);
 
                return error;
@@ -177,8 +175,6 @@
        error = prop_dictionary_sendrecv_ioctl(libdm_task->ldm_task,
            libdm_control_fd, NETBSD_DM_IOCTL, &dict);
        if ( error != 0) {
-               libdm_task_destroy(libdm_task);
-               libdm_task = NULL;
                libdm_control_close(libdm_control_fd);
                return error;
        }



Home | Main Index | Thread Index | Old Index