[src/trunk]: src/external/cddl/osnet/dist/uts/common/fs/zfs Avoid unnecessary...

[riastradh <riastradh%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/61d35e000e79
branches:  trunk
changeset: 1008040:61d35e000e79
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Sun Mar 08 19:59:45 2020 +0000

description:
Avoid unnecessary zil_commit on rm.

1. Issue zil_commit only if we're actually updating something --
   there's no need to commit if we're unlinking the file or if
   there's no atime update being applied.

2. Issue zil_commit only if the zfs has sync=always set -- for
   sync=standard there's no need for us to commit anything here since
   no application asked for an explicit sync.

Speeds up untarring base.tgz on top of itself by a factor of about
2x, and speeds up rm by a factor of about 10x, on my system with an
SSD SLOG over SATA.  Histogram of unlink, rmdir, and rename timing
shows dramatic reduction in latency for most samples.

(To be fair, this was not an improvement over zfs; issuing the
unnecessary zil_commit was a self-inflicted performance wound.)

diffstat:

 external/cddl/osnet/dist/uts/common/fs/zfs/zfs_vnops.c |  8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diffs (18 lines):

diff -r 28f18f5b85cc -r 61d35e000e79 external/cddl/osnet/dist/uts/common/fs/zfs/zfs_vnops.c
--- a/external/cddl/osnet/dist/uts/common/fs/zfs/zfs_vnops.c    Sun Mar 08 19:24:40 2020 +0000
+++ b/external/cddl/osnet/dist/uts/common/fs/zfs/zfs_vnops.c    Sun Mar 08 19:59:45 2020 +0000
@@ -5858,10 +5858,10 @@
                        zp->z_atime_dirty = 0;
                        dmu_tx_commit(tx);
                }
-       }
-
-       if (zfsvfs->z_log)
-               zil_commit(zfsvfs->z_log, zp->z_id);
+
+               if (zfsvfs->z_os->os_sync == ZFS_SYNC_ALWAYS)
+                       zil_commit(zfsvfs->z_log, zp->z_id);
+       }
 
        if (zp->z_sa_hdl == NULL)
                zfs_znode_free(zp);