[src/trunk]: src/lib/libcurses Pads are not to be automatically refreshed on ...

[uwe <uwe%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/987b3d7e4362
branches:  trunk
changeset: 1011703:987b3d7e4362
user:      uwe <uwe%NetBSD.org@localhost>
date:      Mon Jul 06 23:33:38 2020 +0000

description:
Pads are not to be automatically refreshed on input.

X/Open Curses says in the documentation for newpad():

  Automatic refreshes of pads (e.g., from scrolling or echoing of
  input) do not occur.

And in the documentation for get*():

  If the current or specified window is not a pad, and it has been
  moved or modified since the last refresh operation, then it will be
  refreshed before another character is read.

>From Michael Forney in PR lib/55457

diffstat:

 lib/libcurses/get_wch.c |   6 +++---
 lib/libcurses/getch.c   |  14 +++++++-------
 2 files changed, 10 insertions(+), 10 deletions(-)

diffs (62 lines):

diff -r 0c122a7e9be5 -r 987b3d7e4362 lib/libcurses/get_wch.c
--- a/lib/libcurses/get_wch.c   Mon Jul 06 23:31:36 2020 +0000
+++ b/lib/libcurses/get_wch.c   Mon Jul 06 23:33:38 2020 +0000
@@ -1,4 +1,4 @@
-/*   $NetBSD: get_wch.c,v 1.23 2019/06/09 07:40:14 blymn Exp $ */
+/*   $NetBSD: get_wch.c,v 1.24 2020/07/06 23:33:38 uwe Exp $ */
 
 /*
  * Copyright (c) 2005 The NetBSD Foundation Inc.
@@ -36,7 +36,7 @@
 
 #include <sys/cdefs.h>
 #ifndef lint
-__RCSID("$NetBSD: get_wch.c,v 1.23 2019/06/09 07:40:14 blymn Exp $");
+__RCSID("$NetBSD: get_wch.c,v 1.24 2020/07/06 23:33:38 uwe Exp $");
 #endif                                           /* not lint */
 
 #include <errno.h>
@@ -499,7 +499,7 @@
            && __echoit)
                return ERR;
 
-       if (is_wintouched(win))
+       if (!(win->flags & __ISPAD) && is_wintouched(win))
                wrefresh(win);
 #ifdef DEBUG
        __CTRACE(__CTRACE_INPUT, "wget_wch: __echoit = %d, "
diff -r 0c122a7e9be5 -r 987b3d7e4362 lib/libcurses/getch.c
--- a/lib/libcurses/getch.c     Mon Jul 06 23:31:36 2020 +0000
+++ b/lib/libcurses/getch.c     Mon Jul 06 23:33:38 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: getch.c,v 1.74 2020/05/14 11:50:04 simonb Exp $        */
+/*     $NetBSD: getch.c,v 1.75 2020/07/06 23:33:38 uwe Exp $   */
 
 /*
  * Copyright (c) 1981, 1993, 1994
@@ -34,7 +34,7 @@
 #if 0
 static char sccsid[] = "@(#)getch.c    8.2 (Berkeley) 5/4/94";
 #else
-__RCSID("$NetBSD: getch.c,v 1.74 2020/05/14 11:50:04 simonb Exp $");
+__RCSID("$NetBSD: getch.c,v 1.75 2020/07/06 23:33:38 uwe Exp $");
 #endif
 #endif                                 /* not lint */
 
@@ -818,11 +818,11 @@
            && __echoit)
                return ERR;
 
-       if (is_wintouched(win))
-               wrefresh(win);
-       else {
-               if ((_cursesi_screen->curscr->cury != (win->begy + win->cury))
-                   || (_cursesi_screen->curscr->curx != (win->begx + win->curx))) {
+       if (!(win->flags & __ISPAD)) {
+               if (is_wintouched(win))
+                       wrefresh(win);
+               else if ((_cursesi_screen->curscr->cury != (win->begy + win->cury))
+                        || (_cursesi_screen->curscr->curx != (win->begx + win->curx))) {
 #ifdef DEBUG
                        __CTRACE(__CTRACE_INPUT, "wgetch: curscr cury %d cury %d curscr curx %d curx %d\n",
                        _cursesi_screen->curscr->cury, win->begy + win->cury,