Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev/pci remove call to bnx_alloc_pkts() from bnx_init_tx...



details:   https://anonhg.NetBSD.org/src/rev/7480adabbec9
branches:  trunk
changeset: 1011872:7480adabbec9
user:      jdolecek <jdolecek%NetBSD.org@localhost>
date:      Tue Jul 14 12:15:16 2020 +0000

description:
remove call to bnx_alloc_pkts() from bnx_init_tx_chain() - it can
be called from softint context via bnx_watchdog(), and bnx_alloc_pkts()
dmamap allocation can't run in (soft)interrupt context

diffstat:

 sys/dev/pci/if_bnx.c |  7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diffs (28 lines):

diff -r 25befbadd52f -r 7480adabbec9 sys/dev/pci/if_bnx.c
--- a/sys/dev/pci/if_bnx.c      Tue Jul 14 12:04:46 2020 +0000
+++ b/sys/dev/pci/if_bnx.c      Tue Jul 14 12:15:16 2020 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_bnx.c,v 1.97 2020/07/14 10:26:34 jdolecek Exp $     */
+/*     $NetBSD: if_bnx.c,v 1.98 2020/07/14 12:15:16 jdolecek Exp $     */
 /*     $OpenBSD: if_bnx.c,v 1.101 2013/03/28 17:21:44 brad Exp $       */
 
 /*-
@@ -35,7 +35,7 @@
 #if 0
 __FBSDID("$FreeBSD: src/sys/dev/bce/if_bce.c,v 1.3 2006/04/13 14:12:26 ru Exp $");
 #endif
-__KERNEL_RCSID(0, "$NetBSD: if_bnx.c,v 1.97 2020/07/14 10:26:34 jdolecek Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_bnx.c,v 1.98 2020/07/14 12:15:16 jdolecek Exp $");
 
 /*
  * The following controllers are supported by this driver:
@@ -4170,9 +4170,6 @@
 
        DBPRINT(sc, BNX_VERBOSE_RESET, "Entering %s()\n", __func__);
 
-       /* Force an allocation of some dmamaps for tx up front */
-       bnx_alloc_pkts(NULL, sc);
-
        /* Set the initial TX producer/consumer indices. */
        sc->tx_prod = 0;
        sc->tx_cons = 0;



Home | Main Index | Thread Index | Old Index