[src/trunk]: src/usr.bin/xlint/lint1 lint: clean up typeok_ordered_comparison

[rillig <rillig%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/729e34d2c1a7
branches:  trunk
changeset: 1017976:729e34d2c1a7
user:      rillig <rillig%NetBSD.org@localhost>
date:      Sun Jan 17 16:01:19 2021 +0000

description:
lint: clean up typeok_ordered_comparison

diffstat:

 usr.bin/xlint/lint1/tree.c |  11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diffs (46 lines):

diff -r edb4adc29f3e -r 729e34d2c1a7 usr.bin/xlint/lint1/tree.c
--- a/usr.bin/xlint/lint1/tree.c        Sun Jan 17 16:00:16 2021 +0000
+++ b/usr.bin/xlint/lint1/tree.c        Sun Jan 17 16:01:19 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: tree.c,v 1.174 2021/01/17 15:40:27 rillig Exp $        */
+/*     $NetBSD: tree.c,v 1.175 2021/01/17 16:01:19 rillig Exp $        */
 
 /*
  * Copyright (c) 1994, 1995 Jochen Pohl
@@ -37,7 +37,7 @@
 
 #include <sys/cdefs.h>
 #if defined(__RCSID) && !defined(lint)
-__RCSID("$NetBSD: tree.c,v 1.174 2021/01/17 15:40:27 rillig Exp $");
+__RCSID("$NetBSD: tree.c,v 1.175 2021/01/17 16:01:19 rillig Exp $");
 #endif
 
 #include <float.h>
@@ -959,7 +959,7 @@
 }
 
 static bool
-typeok_ordered_comparison(op_t op, const mod_t *mp,
+typeok_ordered_comparison(op_t op,
                          const tnode_t *ln, const type_t *ltp, tspec_t lt,
                          const tnode_t *rn, const type_t *rtp, tspec_t rt)
 {
@@ -971,7 +971,7 @@
                            "pointer" : "integer";
                        /* illegal combination of %s (%s) and ... */
                        warning(123, lx, type_name(ltp),
-                           rx, type_name(rtp), mp->m_name);
+                           rx, type_name(rtp), getopname(op));
                } else {
                        warn_incompatible_types(op, lt, rt);
                        return false;
@@ -1320,8 +1320,7 @@
        case GT:
        case LE:
        case GE:
-               if (!typeok_ordered_comparison(op, mp,
-                   ln, ltp, lt, rn, rtp, rt))
+               if (!typeok_ordered_comparison(op, ln, ltp, lt, rn, rtp, rt))
                        return false;
                break;
        case QUEST: