[src/trunk]: src/usr.bin/make make: document two previously unknown bugs in j...

[rillig <rillig%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/0dbfd00ee3f6
branches:  trunk
changeset: 1020553:0dbfd00ee3f6
user:      rillig <rillig%NetBSD.org@localhost>
date:      Thu Apr 15 18:21:27 2021 +0000

description:
make: document two previously unknown bugs in job mode

diffstat:

 usr.bin/make/job.c |  14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)

diffs (42 lines):

diff -r 6f28e0eec4a0 -r 0dbfd00ee3f6 usr.bin/make/job.c
--- a/usr.bin/make/job.c        Thu Apr 15 17:31:15 2021 +0000
+++ b/usr.bin/make/job.c        Thu Apr 15 18:21:27 2021 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: job.c,v 1.424 2021/04/04 10:05:08 rillig Exp $ */
+/*     $NetBSD: job.c,v 1.425 2021/04/15 18:21:27 rillig Exp $ */
 
 /*
  * Copyright (c) 1988, 1989, 1990 The Regents of the University of California.
@@ -142,7 +142,7 @@
 #include "trace.h"
 
 /*     "@(#)job.c      8.2 (Berkeley) 3/19/94" */
-MAKE_RCSID("$NetBSD: job.c,v 1.424 2021/04/04 10:05:08 rillig Exp $");
+MAKE_RCSID("$NetBSD: job.c,v 1.425 2021/04/15 18:21:27 rillig Exp $");
 
 /*
  * A shell defines how the commands are run.  All commands for a target are
@@ -1834,7 +1834,9 @@
                        break;
                } else if (job->outBuf[i] == '\0') {
                        /*
-                        * Why?
+                        * FIXME: The null characters are only replaced with
+                        * space in the last line.  Everywhere else they hide
+                        * the rest of the command output.
                         */
                        job->outBuf[i] = ' ';
                }
@@ -1866,6 +1868,12 @@
                if (i >= job->curPos) {
                        char *cp;
 
+                       /*
+                        * FIXME: SwitchOutputTo should be here, according to
+                        * the comment above.  But since PrintOutput does not
+                        * do anything in the default shell, this bug has gone
+                        * unnoticed until now.
+                        */
                        cp = PrintOutput(job->outBuf, &job->outBuf[i]);
 
                        /*