Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/common/lib/libc/arch/sparc64/atomic sparc64/membar_ops: Upgr...



details:   https://anonhg.NetBSD.org/src/rev/737d073dbd45
branches:  trunk
changeset: 365140:737d073dbd45
user:      riastradh <riastradh%NetBSD.org@localhost>
date:      Sat Apr 09 22:53:25 2022 +0000

description:
sparc64/membar_ops: Upgrade membar_enter from R/RW to RW/RW.

This will be deprecated soon but let's avoid leaving rakes to trip on
with it arising from disagreement over the documentation (W/RW) and
implementation and usage (R/RW).

diffstat:

 common/lib/libc/arch/sparc64/atomic/membar_ops.S |  11 ++++++-----
 1 files changed, 6 insertions(+), 5 deletions(-)

diffs (32 lines):

diff -r 86fca5833225 -r 737d073dbd45 common/lib/libc/arch/sparc64/atomic/membar_ops.S
--- a/common/lib/libc/arch/sparc64/atomic/membar_ops.S  Sat Apr 09 22:53:17 2022 +0000
+++ b/common/lib/libc/arch/sparc64/atomic/membar_ops.S  Sat Apr 09 22:53:25 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: membar_ops.S,v 1.7 2022/04/09 12:06:47 riastradh Exp $ */
+/*     $NetBSD: membar_ops.S,v 1.8 2022/04/09 22:53:25 riastradh Exp $ */
 
 /*-
  * Copyright (c) 2007 The NetBSD Foundation, Inc.
@@ -35,8 +35,9 @@
 
 /*
  * These assume Total Store Order (TSO), which may reorder
- * store-before-load but nothing else.  Hence, only membar_sync must
- * issue anything -- namely, membar #StoreLoad.
+ * store-before-load but nothing else.  Hence, only membar_sync (and
+ * its deprecated alias membar_enter) must issue anything -- namely,
+ * membar #StoreLoad.
  *
  * If we ran with Partial Store Order (PSO), we would also need to
  * issue membar #StoreStore for membar_exit (load/store-before-store)
@@ -73,8 +74,8 @@
 ATOMIC_OP_ALIAS(membar_producer,_membar_consumer)
 STRONG_ALIAS(_membar_producer,_membar_consumer)
 ATOMIC_OP_ALIAS(membar_consumer,_membar_consumer)
-ATOMIC_OP_ALIAS(membar_enter,_membar_consumer)
-STRONG_ALIAS(_membar_enter,_membar_consumer)
+ATOMIC_OP_ALIAS(membar_enter,_membar_sync)
+STRONG_ALIAS(_membar_enter,_membar_sync)
 ATOMIC_OP_ALIAS(membar_exit,_membar_consumer)
 STRONG_ALIAS(_membar_exit,_membar_consumer)
 ATOMIC_OP_ALIAS(membar_sync,_membar_sync)



Home | Main Index | Thread Index | Old Index