[src/trunk]: src/sys/arch/x86/isa Disable FADT LEGACY_DEVICES flag test.

[jmcneill <jmcneill%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/411750ab2b90
branches:  trunk
changeset: 365233:411750ab2b90
user:      jmcneill <jmcneill%NetBSD.org@localhost>
date:      Fri Apr 15 17:53:44 2022 +0000

description:
Disable FADT LEGACY_DEVICES flag test.

This test had the unintended side-effect of blocking the lm(4) driver
from attaching on more than one system. Go back to (slow) probing of
ISA devices for now to restore existing functionality.

diffstat:

 sys/arch/x86/isa/isa_machdep.c |  13 +++++++++++--
 1 files changed, 11 insertions(+), 2 deletions(-)

diffs (41 lines):

diff -r 8adf52184ece -r 411750ab2b90 sys/arch/x86/isa/isa_machdep.c
--- a/sys/arch/x86/isa/isa_machdep.c    Fri Apr 15 17:08:21 2022 +0000
+++ b/sys/arch/x86/isa/isa_machdep.c    Fri Apr 15 17:53:44 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: isa_machdep.c,v 1.51 2021/12/17 06:28:20 skrll Exp $   */
+/*     $NetBSD: isa_machdep.c,v 1.52 2022/04/15 17:53:44 jmcneill Exp $        */
 
 /*-
  * Copyright (c) 1996, 1997, 1998 The NetBSD Foundation, Inc.
@@ -65,7 +65,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: isa_machdep.c,v 1.51 2021/12/17 06:28:20 skrll Exp $");
+__KERNEL_RCSID(0, "$NetBSD: isa_machdep.c,v 1.52 2022/04/15 17:53:44 jmcneill Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -373,6 +373,13 @@
                prop_dictionary_set_bool(device_properties(dev),
                    "no-legacy-devices", true);
 #if NACPICA > 0
+#if notyet
+       /*
+        * The following code block is technically correct, but unfortunately
+        * it breaks things like being able to use lm(4) on platforms that
+        * have no other means of exposing temperature, fan, and voltage
+        * sensors.
+        */
        if (device_is_a(dev, "isa") && acpi_active) {
                /*
                 * For FACP >= 2, the LEGACY_DEVICES flag indicates that
@@ -387,6 +394,8 @@
                            "no-legacy-devices", true);
                }
        }
+#endif
+
        if (vm_guest == VM_GUEST_VMWARE &&
            device_is_a(dev, "isa") && acpi_active) {
                prop_dictionary_set_bool(device_properties(dev),