Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/uvm/pmap For PMAP_PV_TRACK_ONLY_STUBS, comment out pmap_...



details:   https://anonhg.NetBSD.org/src/rev/5d360b3b84ac
branches:  trunk
changeset: 366006:5d360b3b84ac
user:      rin <rin%NetBSD.org@localhost>
date:      Sun May 08 21:55:34 2022 +0000

description:
For PMAP_PV_TRACK_ONLY_STUBS, comment out pmap_pv_{,un}track().

If modules call these functions, the result should be an
inconsistent state.

Such modules require real PV-tracking support, anyway.

The best we can do should be to make two symbols undefined, and
prevent these modules from loaded.

diffstat:

 sys/uvm/pmap/pmap_pvt.c |  30 +++++++++++++++++++++---------
 1 files changed, 21 insertions(+), 9 deletions(-)

diffs (60 lines):

diff -r 982ccde207a1 -r 5d360b3b84ac sys/uvm/pmap/pmap_pvt.c
--- a/sys/uvm/pmap/pmap_pvt.c   Sun May 08 21:29:20 2022 +0000
+++ b/sys/uvm/pmap/pmap_pvt.c   Sun May 08 21:55:34 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: pmap_pvt.c,v 1.12 2022/05/07 06:53:16 rin Exp $        */
+/*     $NetBSD: pmap_pvt.c,v 1.13 2022/05/08 21:55:34 rin Exp $        */
 
 /*-
  * Copyright (c) 2014, 2020 The NetBSD Foundation, Inc.
@@ -30,7 +30,7 @@
  */
 
 #include <sys/cdefs.h>
-__RCSID("$NetBSD: pmap_pvt.c,v 1.12 2022/05/07 06:53:16 rin Exp $");
+__RCSID("$NetBSD: pmap_pvt.c,v 1.13 2022/05/08 21:55:34 rin Exp $");
 
 #include <sys/param.h>
 #include <sys/atomic.h>
@@ -189,22 +189,34 @@
 
 }
 
+struct pmap_page *
+pmap_pv_tracked(paddr_t pa)
+{
+
+       return NULL;
+}
+
+#if notdef
+/*
+ * pmap_pv_{,un}track() are intentionally commented out. If modules
+ * call these functions, the result should be an inconsistent state.
+ *
+ * Such modules require real PV-tracking support. Let us make two
+ * symbols undefined, and prevent these modules from loaded.
+ */
 void
 pmap_pv_track(paddr_t start, psize_t size)
 {
 
+       panic("PV-tracking not supported");
 }
 
 void
 pmap_pv_untrack(paddr_t start, psize_t size)
 {
 
+       panic("PV-tracking not supported");
 }
+#endif /* notdef */
 
-struct pmap_page *
-pmap_pv_tracked(paddr_t pa)
-{
-
-       return NULL;
-}
-#endif
+#endif /* !PMAP_PV_TRACK_ONLY_STUBS */



Home | Main Index | Thread Index | Old Index