Source-Changes-HG archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

[src/trunk]: src/sys/dev Remove unneeded bus_space_barrier() calls.



details:   https://anonhg.NetBSD.org/src/rev/05b79bab5442
branches:  trunk
changeset: 368449:05b79bab5442
user:      thorpej <thorpej%NetBSD.org@localhost>
date:      Tue Jul 12 02:10:16 2022 +0000

description:
Remove unneeded bus_space_barrier() calls.

diffstat:

 sys/dev/eisa/mlx_eisa.c |  7 ++-----
 sys/dev/vme/if_ie_vme.c |  8 ++------
 2 files changed, 4 insertions(+), 11 deletions(-)

diffs (71 lines):

diff -r 4427a0dc25e8 -r 05b79bab5442 sys/dev/eisa/mlx_eisa.c
--- a/sys/dev/eisa/mlx_eisa.c   Tue Jul 12 02:06:07 2022 +0000
+++ b/sys/dev/eisa/mlx_eisa.c   Tue Jul 12 02:10:16 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: mlx_eisa.c,v 1.29 2021/07/24 19:06:25 thorpej Exp $    */
+/*     $NetBSD: mlx_eisa.c,v 1.30 2022/07/12 02:12:26 thorpej Exp $    */
 
 /*-
  * Copyright (c) 2001 The NetBSD Foundation, Inc.
@@ -34,7 +34,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: mlx_eisa.c,v 1.29 2021/07/24 19:06:25 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: mlx_eisa.c,v 1.30 2022/07/12 02:12:26 thorpej Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -221,9 +221,6 @@
                /* Copy mailbox data to window. */
                bus_space_write_region_1(mlx->mlx_iot, mlx->mlx_ioh,
                    MLX_V1REG_MAILBOX, mc->mc_mbox, 13);
-               bus_space_barrier(mlx->mlx_iot, mlx->mlx_ioh,
-                   MLX_V1REG_MAILBOX, 13,
-                   BUS_SPACE_BARRIER_WRITE);
 
                /* Post command. */
                mlx_outb(mlx, MLX_V1REG_IDB, MLX_V1_IDB_FULL);
diff -r 4427a0dc25e8 -r 05b79bab5442 sys/dev/vme/if_ie_vme.c
--- a/sys/dev/vme/if_ie_vme.c   Tue Jul 12 02:06:07 2022 +0000
+++ b/sys/dev/vme/if_ie_vme.c   Tue Jul 12 02:10:16 2022 +0000
@@ -1,4 +1,4 @@
-/*     $NetBSD: if_ie_vme.c,v 1.34 2021/10/24 20:00:12 andvar Exp $    */
+/*     $NetBSD: if_ie_vme.c,v 1.35 2022/07/12 02:10:16 thorpej Exp $   */
 
 /*
  * Copyright (c) 1995 Charles D. Cranor
@@ -140,7 +140,7 @@
  */
 
 #include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: if_ie_vme.c,v 1.34 2021/10/24 20:00:12 andvar Exp $");
+__KERNEL_RCSID(0, "$NetBSD: if_ie_vme.c,v 1.35 2022/07/12 02:10:16 thorpej Exp $");
 
 #include <sys/param.h>
 #include <sys/systm.h>
@@ -376,7 +376,6 @@
 {
        uint16_t v;
 
-       bus_space_barrier(sc->bt, sc->bh, offset, 2, BUS_SPACE_BARRIER_READ);
        v = bus_space_read_2(sc->bt, sc->bh, offset);
        return (((v&0xff)<<8) | ((v>>8)&0xff));
 }
@@ -386,7 +385,6 @@
 {
        int v0 = ((((v)&0xff)<<8) | (((v)>>8)&0xff));
        bus_space_write_2(sc->bt, sc->bh, offset, v0);
-       bus_space_barrier(sc->bt, sc->bh, offset, 2, BUS_SPACE_BARRIER_WRITE);
 }
 
 void
@@ -403,8 +401,6 @@
        t = (u_char *)&v1;
        t[0] = f[1]; t[1] = 0;
        bus_space_write_2(sc->bt, sc->bh, offset+2, v1);
-
-       bus_space_barrier(sc->bt, sc->bh, offset, 4, BUS_SPACE_BARRIER_WRITE);
 }
 
 int



Home | Main Index | Thread Index | Old Index