[src-draft/trunk]: src/sys/dev/usb xfers need to be queued only in urtwn_init.

[Nathanial Sloss <nat%netbsd.org@localhost>]

details:   https://anonhg.NetBSD.org/src-all/rev/662016bd276c
branches:  trunk
changeset: 375411:662016bd276c
user:      Nathanial Sloss <nat%netbsd.org@localhost>
date:      Sun May 03 09:01:31 2020 +1000

description:
xfers need to be queued only in urtwn_init.

diffstat:

 sys/dev/usb/if_urtwn.c |  31 ++++++++++++++++---------------
 1 files changed, 16 insertions(+), 15 deletions(-)

diffs (62 lines):

diff -r a2578c1adf2b -r 662016bd276c sys/dev/usb/if_urtwn.c
--- a/sys/dev/usb/if_urtwn.c    Sun May 03 08:38:56 2020 +1000
+++ b/sys/dev/usb/if_urtwn.c    Sun May 03 09:01:31 2020 +1000
@@ -390,7 +390,6 @@ urtwn_attach(device_t parent, device_t s
        struct usb_attach_arg *uaa = aux;
        char *devinfop;
        const struct urtwn_dev *dev;
-       struct urtwn_rx_data *data;
        usb_device_request_t req;
        // NNN loop below size_t i;
        int error;
@@ -619,20 +618,6 @@ urtwn_attach(device_t parent, device_t s
                goto fail;
        }
 
-       /* Queue Rx xfers. */
-       for (size_t j = 0; j < sc->rx_npipe; j++) {
-               mutex_enter(&sc->sc_rx_mtx); 
-               TAILQ_FOREACH(data, &sc->rx_free_list[j], next) {
-                       usbd_setup_xfer(data->xfer, data, data->buf,
-                           URTWN_RXBUFSZ, USBD_SHORT_XFER_OK, USBD_NO_TIMEOUT,
-                           urtwn_rxeof);
-                       error = usbd_transfer(data->xfer);
-                       if (__predict_false(error != USBD_NORMAL_COMPLETION &&
-                           error != USBD_IN_PROGRESS))
-                               goto fail;
-               }
-               mutex_exit(&sc->sc_rx_mtx);
-       }
        return;
 
  fail:
@@ -5545,6 +5530,7 @@ urtwn_init(struct ifnet *ifp)
        struct ieee80211com *ic = vap->iv_ic;
        struct ifmediareq imr;
        struct urtwn_softc *sc = ic->ic_softc;
+       struct urtwn_rx_data *data;
        uint32_t reg;
        int error;
 
@@ -5760,6 +5746,21 @@ urtwn_init(struct ifnet *ifp)
        /* Set default channel. */
        urtwn_set_chan(sc, ic->ic_curchan, IEEE80211_HTINFO_2NDCHAN_NONE);
 
+       /* Queue Rx xfers. */
+       for (size_t j = 0; j < sc->rx_npipe; j++) {
+               mutex_enter(&sc->sc_rx_mtx); 
+               TAILQ_FOREACH(data, &sc->rx_free_list[j], next) {
+                       usbd_setup_xfer(data->xfer, data, data->buf,
+                           URTWN_RXBUFSZ, USBD_SHORT_XFER_OK, USBD_NO_TIMEOUT,
+                           urtwn_rxeof);
+                       error = usbd_transfer(data->xfer);
+                       if (__predict_false(error != USBD_NORMAL_COMPLETION &&
+                           error != USBD_IN_PROGRESS))
+                               goto fail;
+               }
+               mutex_exit(&sc->sc_rx_mtx);
+       }
+
        /* We're ready to go. */
        ifp->if_flags &= ~IFF_OACTIVE;
        ifp->if_flags |= IFF_RUNNING;