[src/trunk]: src/crypto centralize the warnings, try to fix clang

[christos <christos%NetBSD.org@localhost>]

details:   https://anonhg.NetBSD.org/src/rev/70095adf38ae
branches:  trunk
changeset: 375966:70095adf38ae
user:      christos <christos%NetBSD.org@localhost>
date:      Tue May 23 12:05:10 2023 +0000

description:
centralize the warnings, try to fix clang

diffstat:

 crypto/Makefile.openssl |  21 +++++++++++++++++++--
 1 files changed, 19 insertions(+), 2 deletions(-)

diffs (38 lines):

diff -r 4c483294a4c6 -r 70095adf38ae crypto/Makefile.openssl
--- a/crypto/Makefile.openssl   Tue May 23 12:04:42 2023 +0000
+++ b/crypto/Makefile.openssl   Tue May 23 12:05:10 2023 +0000
@@ -1,15 +1,32 @@
-#      $NetBSD: Makefile.openssl,v 1.15 2023/05/18 12:01:58 martin Exp $
+#      $NetBSD: Makefile.openssl,v 1.16 2023/05/23 12:05:10 christos Exp $
 
 .ifndef _MAKEFILE_OPENSSL_INCLUDED
 _MAKEFILE_OPENSSL_INCLUDED=1
 
 .include <bsd.own.mk>
 WARNS=3
+
 # would require changing a lot of code
-COPTS+= -Wno-error=cast-qual -Wno-error=discarded-qualifiers
+COPTS+= -Wno-error=cast-qual
 COPTS+= -Wno-error=missing-field-initializers -Wno-error=char-subscripts
 COPTS+= -Wno-error=shadow
 
+CWARNFLAGS.gcc+= -Wno-error=discarded-qualifiers
+CWARNFLAGS.clang+= -Wno-error=ignored-qualifiers
+
+# XXX: re-examine the below
+CWARNFLAGS.clang+= -Wno-empty-body -Wno-unused-value -Wno-parentheses
+CWARNFLAGS.clang+= -Wno-implicit-int-float-conversion
+# XXX: This warning seems to trigger incorrectly
+CWARNFLAGS.clang+=     -Wno-atomic-alignment
+
+LINTFLAGS+=    -X 161  # constant in conditional context
+LINTFLAGS+=    -X 129  # expression has null effect
+LINTFLAGS+=    -X 117  # bitwise '>>' on signed value possibly nonportable
+LINTFLAGS+=    -X 231  # argument '%s' unused in function '%s'
+LINTFLAGS+=    -X 220  # fallthrough on case statement
+LINTFLAGS+=    -X 118  # semantics of '%s' change in ANSI C; use explicit cast
+
 
 .if ${HAVE_OPENSSL} <= 11
 OSSL_ENGINESDIR=/usr/lib/openssl