Subject: Re: CVS commit: syssrc
To: Paul Kranenburg <pk@cs.few.eur.nl>
From: Manuel Bouyer <bouyer@antioche.lip6.fr>
List: source-changes
Date: 05/18/2000 19:57:00
On Thu, May 18, 2000 at 05:15:14PM +0200, Paul Kranenburg wrote:
> > Modified Files:
> > syssrc/sys/dev/ic: hme.c
> >
> > Log Message:
> > rearrange the order of bus_dma operations to be more like many other
> > drivers, at the suggestion of fvdl. also, use bus_dmamap_load() not
> > load_raw().
>
> You're headed for trouble with this change. According to bus_dma(9),
> memory allocated with bus_dmamem_alloc() should be loaded with
> bus_dmamap_load_raw().
I don't read it this way. bus_dmamap_load_raw() is "a variation of
bus_dmamap_load()". I don't see anything saying that memory allocated by
bus_dmamem_alloc() has to be handled in a different way than any other
memory buffer. The only constraint I see is that memory allocated by
bus_dmamem_alloc() should be mapped in kernel memory space with
bus_dmamem_map().
--
Manuel Bouyer <bouyer@antioche.eu.org>
--