Subject: Re: CVS commit: syssrc
To: Nathan J. Williams <nathanw@MIT.EDU>
From: Jason R Thorpe <thorpej@zembu.com>
List: source-changes
Date: 02/05/2001 09:59:05
On Mon, Feb 05, 2001 at 12:50:07PM -0500, Nathan J. Williams wrote:
> > Log Message:
> > expose the definitions of MIN() and MAX() in sys/param.h to the kernel
> > and use those in favor of a dozen copies scattered around the source tree.
>
> We have had min() and max() and a few other flavors of this function
> in libkern.h for a while. I had thought that that was the canonical
> location. Having only two copies is better than having a dozen copies,
> but might we settle on just one?
We should probably just use the MIN()/MAX() macro versions -- the use of
min()/max() led to unfortunate UBC bugs.
--
-- Jason R. Thorpe <thorpej@zembu.com>