Subject: Re: CVS commit: syssrc
To: Jaromir Dolecek <jdolecek@netbsd.org>
From: Noriyuki Soda <soda@sra.co.jp>
List: source-changes
Date: 02/14/2001 14:24:32
Jaromir Dolecek <jdolecek@netbsd.org> wrote:
> Modified Files:
> syssrc/sys/ntfs: ntfs.h ntfs_subr.c ntfs_subr.h ntfs_vfsops.c
> ntfs_vnops.c
>
> Log Message:
> Add per-mount filename conversion and compare hooks, which can be used
> to recode Unicode names to other representation,
Why does this "per mount" flag?
Certainly msdosfs needs per mount flag.
But ntfs shouldn't need such flag.
What ntfs needs is either
- system global codeset
or
- per process codeset
Isn't it?
Unless some justification is made, I strongly believe that
ntm_w{get,put,cmp} member should be moved from "struct ntfsmount"
to global variable.
--
soda