Subject: Re: CVS commit: syssrc
To: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
From: Jason R Thorpe <thorpej@zembu.com>
List: source-changes
Date: 02/23/2001 18:33:49
On Sat, Feb 24, 2001 at 11:15:28AM +0900, Izumi Tsutsui wrote:

 > BTW, isp_sbus.c has some bus_dmamap_sync calls like:
 > 
 > 	bus_dmamap_sync(sbc->sbus_dmatag, dmap, dmap->dm_segs[0].ds_addr,
 > 	    xs->datalen, in? BUS_DMASYNC_PREREAD : BUS_DMASYNC_PREWRITE);
 > 
 > It looks completely wrong to specify dm_segs[].ds_addr for offset.

That is also correct -- the map already has the addr -- so, to sync
the entire range of the map, the offset should be 0, and the length
should be xs->datalen.

-- 
        -- Jason R. Thorpe <thorpej@zembu.com>