Subject: Re: CVS commit: basesrc
To: None <jdc@netbsd.org>
From: Chris Gilbert <chris@paradox.demon.co.uk>
List: source-changes
Date: 04/20/2001 23:10:51
Hi Julian,

This change seems to have made builds break (although the lint warning looks 
wrong?)

At a guess curses.h needs updating/get missed from the cvs ci?

Cheers,
Chris

lint -chapbxzF -D_CURSES_PRIVATE -I/extra/cvs/src/lib/libcurses 
-I/extra/cvs/src/lib/libcurses/../libterm -DCM_N -DCM_GT -DCM_B -DCM_D -i 
/extra/cvs/src/lib/libcurses/getstr.c
/extra/cvs/src/lib/libcurses/getstr.c(173): warning: prevx set but not used 
in function __wgetnstr [191]
cc -O2  -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith 
-Wno-uninitialized -Werror    -D_CURSES_PRIVATE 
-I/extra/cvs/src/lib/libcurses -I/extra/cvs/src/lib/libcurses/../libterm 
-DCM_N -DCM_GT -DCM_B -DCM_D -c /extra/cvs/src/lib/libcurses/getstr.c cc1: 
warnings being treated as errors
/extra/cvs/src/lib/libcurses/getstr.c:58: warning: no previous prototype for 
`getnstr'
/extra/cvs/src/lib/libcurses/getstr.c: In function `getnstr':
/extra/cvs/src/lib/libcurses/getstr.c:59: warning: implicit declaration of 
function `wgetnstr'
/extra/cvs/src/lib/libcurses/getstr.c: At top level:
/extra/cvs/src/lib/libcurses/getstr.c:80: warning: no previous prototype for 
`mvgetnstr'
/extra/cvs/src/lib/libcurses/getstr.c: In function `mvgetnstr':
/extra/cvs/src/lib/libcurses/getstr.c:81: warning: implicit declaration of 
function `mvwgetnstr'
/extra/cvs/src/lib/libcurses/getstr.c: At top level:
/extra/cvs/src/lib/libcurses/getstr.c:103: warning: no previous prototype for 
`mvwgetnstr'
/extra/cvs/src/lib/libcurses/getstr.c: In function `wgetstr':
/extra/cvs/src/lib/libcurses/getstr.c:136: warning: implicit declaration of 
function `__wgetnstr'
/extra/cvs/src/lib/libcurses/getstr.c: At top level:
/extra/cvs/src/lib/libcurses/getstr.c:146: warning: no previous prototype for 
`wgetnstr'
/extra/cvs/src/lib/libcurses/getstr.c:166: warning: no previous prototype for 
`__wgetnstr'

On Friday 20 April 2001  2:03 pm, you wrote:
> Module Name:	basesrc
> Committed By:	jdc
> Date:		Fri Apr 20 13:03:25 UTC 2001
>
> Modified Files:
> 	basesrc/lib/libcurses: getstr.c
>
> Log Message:
> Implement the getnstr() functions.
> Add __warn_references() for getstr().
> Move getstr() family closer to SUSv2 :
>   add checks for <carriage return>, the kill character, KEY_LEFT and
>   KEY_BACKSPACE
>   ignore other KEY_* characters
>
>
> To generate a diff of this commit:
> cvs rdiff -r1.12 -r1.13 basesrc/lib/libcurses/getstr.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.