Subject: Re: CVS commit: syssrc/sys/sys
To: None <source-changes@netbsd.org>
From: Christos Zoulas <christos@zoulas.com>
List: source-changes
Date: 07/06/2001 03:48:22
In article <87d77fdmo3.fsf@minor-variation.er.reziprozitaet.de>,
Klaus Klein <kleink@reziprozitaet.de> wrote:

I agree with klaus. Please back this out, because it introduces overhead
that is unneeded in 99% of the usage.

christos

>Todd Vierling <tv@netbsd.org> writes:
>
>> Module Name:	syssrc
>> Committed By:	tv
>> Date:		Thu Jul  5 21:51:10 UTC 2001
>> 
>> Modified Files:
>> 	syssrc/sys/sys: systm.h
>> 
>> Log Message:
>> bcopy() is documented as allowing overlapping memory regions.  Define it
>> in terms of the standard name memmove() to account for this.
>> Fixes kern/13369 and the redundant lib/13370.
>
>This change looks wrong to me.  While the libc bcopy() implementation
>is indeed documented as allowing overlapping memory objects, this is
>not the case for its kernel pendant, which led (historically) to the
>alternate version ovbcopy() being used for possibly overlapping
>objects.
>
>
>- Klaus