Subject: Re: CVS commit: basesrc/lib/libc/gen
To: enami tsugutomo <enami@sm.sony.co.jp>
From: Simon Burge <simonb@wasabisystems.com>
List: source-changes
Date: 09/18/2001 16:35:46
enami tsugutomo wrote:
> Simon Burge <simonb@netbsd.org> writes:
>
> > Module Name: basesrc
> > Committed By: simonb
> > Date: Tue Sep 18 05:09:38 UTC 2001
> >
> > Modified Files:
> > basesrc/lib/libc/gen: execvp.c
>
> I guess the first alloca and strcpy is unnecessary. Also, it calls
> strlen within the loop but it always returns same value. How about
> following?
Looks good, and tests ok on an alpha.
Simon.
--
Simon Burge <simonb@wasabisystems.com>
NetBSD CDs, Support and Service: http://www.wasabisystems.com/