Subject: Re: CVS commit: basesrc
To: None <tv@netbsd.org>
From: James Chacon <jchacon@genuity.net>
List: source-changes
Date: 10/23/2001 21:22:50
There was a good reason this wasn't there before and a good reason I put it
back.
Neither distrib or etc should be descended to on a build unless explictly
asked to. Now your assuming that anytime a rules change in bsd.*.mk which
may change internal rule names in some way will be propoaged to etc and
distrib. I guess whomever is doing that will "remember" to come to
etc/distrib and fix it here when that happens.
The last I want is a build descending into etc when I don't have DESTDIR
set and some rule in there torching part of my system's real /etc because
the null rules in there aren't "quite right"...
Plus it's much more effecient to not descend into dirs that are only going
to be used on a make release (and even then distrib is only walked by the
make inside of etc's Makefile)...
As it was, the old behavior was there for a reason, the new behavior broke
the build and posed a much more dangerous setup for everyone to have to bear.
(for what I can is zero gain....simplicity isn't an excuse, the current
Makefile is just as much of a mess as the old one...)
In short I'm not seeing any reason this shouldn't have remained as-is,
especially without some form of discussion first...
James
>
>Module Name: basesrc
>Committed By: tv
>Date: Wed Oct 24 01:07:13 UTC 2001
>
>Modified Files:
> basesrc: Makefile
>
>Log Message:
>Revert previous. etc and distrib do now belong in _SUBDIR; the correct fix
>for broken builds is to fix the relevant Makefiles as was done for sparc.
>This was done in the interest of simplicity of the system build (and the
>fact that there may be a need to descend into these directories in the
>near future).
>
>
>To generate a diff of this commit:
>cvs rdiff -r1.140 -r1.141 basesrc/Makefile
>
>Please note that diffs are not public domain; they are subject to the
>copyright notices on the relevant files.
>
>
>
>
>