Subject: Re: CVS commit: syssrc/sys/netinet6
To: None <itojun@iijlab.net>
From: enami tsugutomo <enami@sm.sony.co.jp>
List: source-changes
Date: 09/04/2002 18:02:35
itojun@iijlab.net writes:

> >> >Then, the else-clause is effectively nop and doesn't match with the
> >> >comment there.
> >> 	need to keep the code for kame sync. (in kame code there's more code
> >> 	inside if {} else {}).
> >``the else-clause''.  Both latest kame and NetBSD code are same
> >regarding this.
> 
> 	ok, but it won't hurt so i'd like to leave it as is.
> 	actually IFA6_IS_DEPRECATED() the right way to detect deprecated-ness,
> 	IN6_IFF_DEPRECATED is a shortcut for it, so i'd like to make suremthey
> 	are in sync.

I mean the following code is never executed once the
IN6_IFF_DEPRECATED bit is set, but is this really what you want?

		} else {
			/*
			 * A new RA might have made a deprecated address
			 * preferred.
			 */
			ia6->ia6_flags &= ~IN6_IFF_DEPRECATED;
		}

enami.