Re: CVS commit: syssrc/sys/lib/libkern

[Chris Gilbert <chris%dokein.co.uk@localhost>]

On Fri, 4 Oct 2002 12:28:03 -0700 (PDT)
Bill Studenmund <wrstuden%netbsd.org@localhost> wrote:

> On Fri, 4 Oct 2002, Bang Jun-Young wrote:
> 
> >
> > Module Name:        syssrc
> > Committed By:       junyoung
> > Date:               Fri Oct  4 18:39:54 UTC 2002
> >
> > Modified Files:
> >     syssrc/sys/lib/libkern: Makefile libkern.h
> > Added Files:
> >     syssrc/sys/lib/libkern: strstr.c
> >
> > Log Message:
> > Add strstr() to libkern. For now, it's only used in i386 (for processor
> > identification).
> 
> I'd say don't conditionalize it. Just add it to libkern. It's not like it
> will go into kernels that don't use it, and there's not obvious reason for
> it to be arch-dependent (it's not like it uses x86-only asm instructions).

If it is for just i386, then why not just add it to the arch/i386/Makefile like 
most libkern files are?

Chris