Subject: Re: CVS commit: syssrc/sys/kern
To: Christos Zoulas <christos@netbsd.org>
From: Bill Studenmund <wrstuden@netbsd.org>
List: source-changes
Date: 10/31/2002 09:05:00
On Thu, 31 Oct 2002, Christos Zoulas wrote:
>
> Module Name: syssrc
> Committed By: christos
> Date: Thu Oct 31 02:40:42 UTC 2002
>
> Modified Files:
> syssrc/sys/kern: exec_macho.c
>
> Log Message:
> XXX: be32toh on powerpc does not cast to int32_t so passing u_long to
> be32toh produces an unsigned long result, causing a printf argument
> mismatch. This is the wrong fix, but I am not going to change the
> powerpc macros; fix the powerpc macros and revert my change.
(not specifically directted at Christos)
Uhm, why are we passing "long" variables to be32toh? If these things are
going to be 32-bit quantities, we should make them 32-bit quantities. Not
longs.
For instance, what happens when we have 64-bit powerpc, and want to run
tthe macho code?
Take care,
Bill